RFC: Making T_FUNCTION optional in method declarations View as Markdown

Am 27.11.2010 18:40, schrieb Johannes Schlüter:

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

+1

--
Sebastian Bergmann Co-Founder and Principal Consultant
http://sebastian-bergmann.de/ http://thePHP.cc/

2010/11/27 Johannes Schlüter johannes@schlueters.de:

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

+1, I've missed being able to skip the function keyword for a while now.

--
regards,

Kalle Sommer Nielsen
kalle@php.net

2010/11/27 Johannes Schlüter johannes@schlueters.de

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

+1

--
Regards,
Felipe Pena

As long as a modifier (public|private|protected) is still required, +1.

2010/11/27 Johannes Schlüter johannes@schlueters.de:

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

       class Foo {
           public bar() {
               echo "Hello World";
           }
       }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

+1

2010/11/27 Johannes Schlüter johannes@schlueters.de

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

   class Foo {
       public bar() {
           echo "Hello World";
       }
   }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

+1, has crossed my mind before =)

"Johannes "Schlüter"" wrote in message
news:1290879624.7033.826.camel@guybrush...

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

    class Foo {
        public bar() {
            echo "Hello World";
        }
    }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

Sorry for moving offtopic, but if the PHP syntax is going to change then we should revisit other proposals that add/change syntax. For example, I think the short syntax for arrays was declined [from 5.3] mainly because it introduced a new syntax at a time we wanted to preserve BC:

• http://wiki.php.net/rfc/shortsyntaxforarrays

Regards,
Philip

+1 to being able to omit the function keyword.

2010/11/27 Johannes Schlüter johannes@schlueters.de:

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

       class Foo {
           public bar() {
               echo "Hello World";
           }
       }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

2010/11/27 Johannes Schlüter johannes@schlueters.de

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

   class Foo {
       public bar() {
           echo "Hello World";
       }
   }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

Happened with me many times also.
+1 for the feature.

Tyrael

+1 for PHP 7.0. :)

Stuff like this accumulating in trunk kinda makes it more and more
something else than minor release..

--Jani

27.11.2010 19:40, Johannes Schlüter kirjoitti:

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

     class Foo {
         public bar() {
             echo "Hello World";
         }
     }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

On 27 nov 2010, at 18:40, Johannes Schlüter johannes@schlueters.de
wrote:

Hi,

every now and then while writing classes I forget to add the
"function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is
not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

   class Foo {
       public bar() {
           echo "Hello World";
       }
   }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/
zend_optional_t_function.diff

FWIW: +1

Though I do have two questions regarding behaviour:
I am currently working on a documentation generator (DocBlox) which
uses the tokenizer to analyze sourcefiles. The T_FUNCTION token is a
clear sign for me that I am dealing with a method (as the visibility
token can also be used with properties).
With this patch I will loose this recognition point and the first
solution that comes to mind is to search for () or arguments. This
sounds rather hackish to me, might I be missing a solution?

Another question is: when would you like to have this released? PHP-
next? (thus either 5.4, 6, 7 or whichever is next?).

Thank you!

--
Kind regards,

Mike van Riel

Hi:

        public bar() {

Not that my vote really counts, but -1. Doing so would eliminate the
helpful ability to grep source code for 'function bar'.

--Dan

--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409

2010/11/27 Johannes Schlüter johannes@schlueters.de:

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

As a plea on behalf of maintenance coders dealing with large, messy
codebases, please, please don't impact our ability to run 'grep -rs
"function functionName" *', or hit F8, or whatever your IDE's
equivalent is.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

I'm -1 on this one. Besides this being confusing for people who want to
run "newer" code on older PHP versions; this change does nothing but
stop you from having to type "function". Something that the parser tells
you immediately that you have forgotten this.

cheers,
Derick

--
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug

2010/11/28 Johannes Schlüter johannes@schlueters.de:

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

I'd be -1 at the moment. The patch is certainly fine, but I think this
has the potential to generate a lot of head-scratchers for neophyte
coders trying to support code across multiple versions, and would
increase our support burden for the benefit of removing a few
keystrokes that every remotely experienced PHP developer already has
committed to muscle memory.

Adam

Hi,

...

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

+1 for any PHP version. Insisting on keeping T_FUNCTION means advocating
PHP to stay the odd anomaly in programming languages to me.

Regards,
Mike

2010/11/27 Johannes Schlüter johannes@schlueters.de

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

       class Foo {
           public bar() {
               echo "Hello World";
           }
       }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

--

Considering variables are prefixed and constants don't have visibility
modifiers, functions in classes would still be easily recognizable.
Syntax analyzing IDEs generally don't rely on single keywords and will
be able to adapt a change like this without too much hassle.

On top of that, seeing that functions in classes are generally
referred to as methods, I believe removing the requirement would
improve consistency.

+1 from me.

Kind regards,
Peter Beverloo

2010/11/27 Johannes Schlüter johannes@schlueters.de:

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

       class Foo {
           public bar() {
               echo "Hello World";
           }
       }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

--

With this patch, something looks inconsistent to me:
Both properties and methods have a visibility
(public|protected|private) and a keyword: "var" (T_VAR) and "function"
(T_FUNCTION) respectively.
However "private var $foo;" generates a fatal error but "private
function foo(){}" not?

Cheers,

Patrick Allaert

http://code.google.com/p/peclapm/ - Alternative PHP Monitor

-1

Hi,

every now and then while writing classes I forget to add the "function"
keyword between my visibility modifier and the method name in a class
declaration. I don't think it is required for readability and it is not
needed by the parser to prevent conflicts, I therefore propose the
following RFC incl. patch to allow writing

    class Foo {
        public bar() {
            echo "Hello World";
        }
    }

Without T_FUNCTION token. In my opinion an access modifier /public,
private protected, static, final) should still be required for keeping
readability.

RFC: http://wiki.php.net/rfc/optional-t-function
Patch: http://schlueters.de/~johannes/php/zend_optional_t_function.diff

johannes

--
Wbr,
Antony Dovgal

http://pinba.org - realtime statistics for PHP

-1

May harm code portability and maintainability, allows intended or accidental
fluctuations in code consistence.

On Sun, Nov 28, 2010 at 6:10 PM, Tjerk Meesters tjerk.meesters@gmail.comwrote:

-1

The nuisance of updating IDE, search tools etc doesn't outweigh typing 9
characters less imho.