BC break: ReflectionMethod::invoke() expects parameter 1 to be object, string given

On Mon, Aug 22, 2016 at 5:17 AM, Nicolas Grekas <
nicolas.grekas+php@gmail.com> wrote:

Hello,

now that the BC break on ReflectionType has been reverted, another one
remains in ReflectionMethod::invoke():

the method doesn't accept a string as first argument anymore, see e.g.:

https://3v4l.org/pImmv

As you can see, this worked since 5.0 and even in HHVM.

It would be great to fix this BC break please.

Regards,
Nicolas

According to the documentation it requires an object. If the
documentation has not been altered recently to make it this way then I'm
inclined to keep the backward compatibility break. Your example uses a
static method - you should be passing null and not the name of the class
(this is also in the documentation).

I have to disagree here.

Many codes out there uses string. What is the appealing reason to break
these codes in 7.1?

I think it should restore the precious behavior and if the docs need a
fix, let fix it, not the other way.

Cheers
Pierre

Hi,

If it was explicitly documented to be expecting an object, then altering
the code to match the documented behavior can be considered a bugfix, but I
agree that if it is moderately/widely used we should consider keeping the
old behavior instead of removing it in a minor version.

--
Ferenc Kovács
@Tyr43l - http://tyrael.hu

If the first argument for invoke() and invokeArgs() for static methods will
be a string with compatible class name for the scope, then it can be used
as a scope modifier (like second argument for Closure::bind($instance,
$scopeClassName))

2016-08-22 17:29 GMT+03:00 Alexander Lisachenko lisachenko.it@gmail.com:

Hello, there is one more issue with ReflectionMethod::invoke() for static
methods: it's impossible to call an overridden parent static method and
preserve a scope information:

// https://3v4l.org/ASntq

class foo
{
static function bar()
{
echo self::class, ' vs ', static::class, PHP_EOL;
}

static function bar1()
{
    echo self::class, ' vs ', static::class, PHP_EOL;
}

}

class baz extends foo
{
static function bar()
{
echo self::class, ' vs ', static::class, PHP_EOL;
}
}

$r = new ReflectionClass('baz');
$m = $r->getMethod('bar1'); // without overriden method - it's ok, our
static scope is preserved
$m->invoke(null); // foo vs baz

$r = new ReflectionClass('baz');
$m = $r->getMethod('bar'); // with overriden method it's impossible to
call parent static method, no way to specify a scope.
$m->invoke(null); // baz vs baz

// how to statically call the parent static method bar() with scope ==
baz??

2016-08-22 17:00 GMT+03:00 Levi Morrison levim@php.net:

On Mon, Aug 22, 2016 at 5:17 AM, Nicolas Grekas <
nicolas.grekas+php@gmail.com> wrote:

Hello,

now that the BC break on ReflectionType has been reverted, another one
remains in ReflectionMethod::invoke():

the method doesn't accept a string as first argument anymore, see e.g.:

https://3v4l.org/pImmv

As you can see, this worked since 5.0 and even in HHVM.

It would be great to fix this BC break please.

Regards,
Nicolas

According to the documentation it requires an object. If the
documentation has not been altered recently to make it this way then I'm
inclined to keep the backward compatibility break. Your example uses a
static method - you should be passing null and not the name of the class
(this is also in the documentation).

It is still ignored if it is a valid object, so the current beta's

behaviour doesn't actually make a lot of sense.
Well, see https://3v4l.org/n8cad. Only as of 7.1.0beta3 ::invoke()
matches the behavior of ::invokeArgs().

OK, so that's a further inconsistency. The current version still doesn't
actually make sense, though. If you want to validate that the correct
argument is being passed, then the only value allowed should be null.

If so desired, I can revert that commit, but I wouldn't be happy with
sticking with a completely unused parameter, which obviously has been
and still is misunderstood.

The parameter is still unused, and can be any object. The only sane
validation would be to check explicitly for null, which is documented as
the correct argument for both invoke() and invokeArgs().

Regards,

Rowan Collins
[IMSoP]