Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95378
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
To: internals@lists.php.net
References: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
Message-ID: <0b8ebd55-976b-f3a9-9f70-de392f2bd8e6@gmail.com>
Date: Mon, 22 Aug 2016 15:38:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter
 1 to be object, string given
From: rowan.collins@gmail.com (Rowan Collins)

On 22/08/2016 12:17, Nicolas Grekas wrote:
> in ReflectionMethod::invoke():
>
> the method doesn't accept a string as first argument anymore, see e.g.:
>
> https://3v4l.org/pImmv

To be precise, in prior versions, the first argument was completely 
ignored for static methods: https://3v4l.org/8o4Hm

$m->invoke('some_other_class_name', 'baz'); // Warns in 7.1.0beta3, 
ignores everywhere else
$m->invoke(42, 'baz'); // Warns in 7.1.0beta3, ignores everywhere else
$m->invoke(new DateTime, 'baz'); // OK in all versions
$m->invoke($m, 'baz'); // OK in all versions

It is still ignored if it is a valid object, so the current beta's 
behaviour doesn't actually make a lot of sense. The most logical would 
be for it to fail on any value other than null, since for a non-static 
method any other object will give "Given object is not an instance of 
the class this method was declared in" (except in HHVM, which just 
invokes on whatever object you give it): https://3v4l.org/sCFcA

However, simply documenting that "the first argument is ignored for 
static methods", and removing the parameter validation, would probably 
be sensible for BC if there is likely to be real-world code passing 
something other than null.

Regards,
-- 
Rowan Collins
[IMSoP]