Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95376
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEbg-4bnvypxViEAJG1+ZVmKt1H06cKojnG2=SMBdGLv3JHDRw@mail.gmail.com>
References: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
 <CAFMT4Np5hwhKCGxf8Eox04u+b_GEk0wpMCJ2T7osmYehDN2ZoA@mail.gmail.com> <CAEbg-4bnvypxViEAJG1+ZVmKt1H06cKojnG2=SMBdGLv3JHDRw@mail.gmail.com>
Date: Mon, 22 Aug 2016 17:32:02 +0300
Message-ID: <CAEbg-4Y51cY1-8=Co-Vdtp4eGPX2x_Qh+ZQ4pYqeKkobweY0TA@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Nicolas Grekas <nicolas.grekas+php@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11498684616186053aa9e936
Subject: Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter
 1 to be object, string given
From: lisachenko.it@gmail.com (Alexander Lisachenko)

--001a11498684616186053aa9e936
Content-Type: text/plain; charset=UTF-8

If the first argument for invoke() and invokeArgs() for static methods will
be a string with compatible class name for the scope, then it can be used
as a scope modifier (like second argument for Closure::bind($instance,
$scopeClassName))

2016-08-22 17:29 GMT+03:00 Alexander Lisachenko <lisachenko.it@gmail.com>:

> Hello, there is one more issue with ReflectionMethod::invoke() for static
> methods: it's impossible to call an overridden parent static method and
> preserve a scope information:
>
> // https://3v4l.org/ASntq
>
> class foo
> {
>     static function bar()
>     {
>         echo self::class, ' vs ', static::class, PHP_EOL;
>     }
>
>     static function bar1()
>     {
>         echo self::class, ' vs ', static::class, PHP_EOL;
>     }
> }
>
> class baz extends foo
> {
>     static function bar()
>     {
>         echo self::class, ' vs ', static::class, PHP_EOL;
>     }
> }
>
> $r = new ReflectionClass('baz');
> $m = $r->getMethod('bar1'); // without overriden method - it's ok, our
> static scope is preserved
> $m->invoke(null); // foo vs baz
>
> $r = new ReflectionClass('baz');
> $m = $r->getMethod('bar'); // with overriden method it's impossible to
> call parent static method, no way to specify a scope.
> $m->invoke(null); // baz vs baz
>
> // how to statically call the parent static method bar() with scope ==
> baz??
>
> 2016-08-22 17:00 GMT+03:00 Levi Morrison <levim@php.net>:
>
>> On Mon, Aug 22, 2016 at 5:17 AM, Nicolas Grekas <
>> nicolas.grekas+php@gmail.com> wrote:
>>
>> > Hello,
>> >
>> > now that the BC break on ReflectionType has been reverted, another one
>> > remains in ReflectionMethod::invoke():
>> >
>> > the method doesn't accept a string as first argument anymore, see e.g.:
>> >
>> > https://3v4l.org/pImmv
>> >
>> > As you can see, this worked since 5.0 and even in HHVM.
>> >
>> > It would be great to fix this BC break please.
>> >
>> > Regards,
>> > Nicolas
>> >
>>
>> According to the [documentation][1] it requires an object. If the
>> documentation has not been altered recently to make it this way then I'm
>> inclined to keep the backward compatibility break. Your example uses a
>> static method - you should be passing null and not the name of the class
>> (this is also in the documentation).
>>
>>   [1]: http://php.net/manual/en/reflectionmethod.invoke.php
>>
>
>

--001a11498684616186053aa9e936--