Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95373
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.42 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
References: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
Date: Mon, 22 Aug 2016 08:00:36 -0600
Message-ID: <CAFMT4Np5hwhKCGxf8Eox04u+b_GEk0wpMCJ2T7osmYehDN2ZoA@mail.gmail.com>
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec5304bc7f42490053aa97845
Subject: Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter
 1 to be object, string given
From: levim@php.net (Levi Morrison)

--bcaec5304bc7f42490053aa97845
Content-Type: text/plain; charset=UTF-8

On Mon, Aug 22, 2016 at 5:17 AM, Nicolas Grekas <
nicolas.grekas+php@gmail.com> wrote:

> Hello,
>
> now that the BC break on ReflectionType has been reverted, another one
> remains in ReflectionMethod::invoke():
>
> the method doesn't accept a string as first argument anymore, see e.g.:
>
> https://3v4l.org/pImmv
>
> As you can see, this worked since 5.0 and even in HHVM.
>
> It would be great to fix this BC break please.
>
> Regards,
> Nicolas
>

According to the [documentation][1] it requires an object. If the
documentation has not been altered recently to make it this way then I'm
inclined to keep the backward compatibility break. Your example uses a
static method - you should be passing null and not the name of the class
(this is also in the documentation).

  [1]: http://php.net/manual/en/reflectionmethod.invoke.php

--bcaec5304bc7f42490053aa97845--