Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95379
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.18 as permitted sender)
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
Message-ID: <4bfa2f62-1b47-633f-3401-59c71c50fc90@gmx.de>
Date: Mon, 22 Aug 2016 17:32:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: BC break: ReflectionMethod::invoke() expects parameter 1 to
 beobject, string given
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 22.08.2016 at 13:17, Nicolas Grekas wrote:

> now that the BC break on ReflectionType has been reverted, another one
> remains in ReflectionMethod::invoke():
> 
> the method doesn't accept a string as first argument anymore, see e.g.:
> 
> https://3v4l.org/pImmv
> 
> As you can see, this worked since 5.0 and even in HHVM.
> 
> It would be great to fix this BC break please.

The BC break is caused by implementing feature requrest #38992
(<https://bugs.php.net/bug.php?id=38992>), which has been posted nearly
10 years ago.

My analysis as posted in the bug report:

| Actually, the first parameter to ReflectionMethod::invoke() is
| completely ignored, if the method is a static method, see
| <https://3v4l.org/e9h1S>. A comment in the sources[1] also
| explains the reasoning.
|
| This doesn't make any sense, however, because for static methods
| to be invoked, NULL is supposed to be passed as first parameter to
| ::invoke() as well as ::invokeArgs(). Allowing an arbitrary
| argument is confusing at best.
|
| Changing the behavior would introduce a BC break, though, so it
| appears to be reasonable to do that for PHP 7.1 only.
|
| [1]
<https://github.com/php/php-src/blob/PHP-7.0.10/ext/reflection/php_reflection.c#L3197-L3202>

If so desired, I can revert that commit, but I wouldn't be happy with
sticking with a completely unused parameter, which obviously has been
and still is misunderstood.

-- 
Christoph M. Becker