Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95374
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4Np5hwhKCGxf8Eox04u+b_GEk0wpMCJ2T7osmYehDN2ZoA@mail.gmail.com>
References: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
 <CAFMT4Np5hwhKCGxf8Eox04u+b_GEk0wpMCJ2T7osmYehDN2ZoA@mail.gmail.com>
Date: Mon, 22 Aug 2016 21:16:40 +0700
Message-ID: <CAEZPtU5x0PdNWs37=avb3YCs9B0Yro9-NNRzpARnKue=9VuGCQ@mail.gmail.com>
To: Levi Morrison <levim@php.net>, Davey Shafik <davey@php.net>, Joe Watkins <pthreads@pthreads.org>
Cc: PHP internals <internals@lists.php.net>, Nicolas Grekas <nicolas.grekas+php@gmail.com>
Content-Type: multipart/alternative; boundary=001a114133bc825319053aa9b293
Subject: Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter
 1 to be object, string given
From: pierre.php@gmail.com (Pierre Joye)

--001a114133bc825319053aa9b293
Content-Type: text/plain; charset=UTF-8

On Aug 22, 2016 9:01 PM, "Levi Morrison" <levim@php.net> wrote:
>
> On Mon, Aug 22, 2016 at 5:17 AM, Nicolas Grekas <
> nicolas.grekas+php@gmail.com> wrote:
>
> > Hello,
> >
> > now that the BC break on ReflectionType has been reverted, another one
> > remains in ReflectionMethod::invoke():
> >
> > the method doesn't accept a string as first argument anymore, see e.g.:
> >
> > https://3v4l.org/pImmv
> >
> > As you can see, this worked since 5.0 and even in HHVM.
> >
> > It would be great to fix this BC break please.
> >
> > Regards,
> > Nicolas
> >
>
> According to the [documentation][1] it requires an object. If the
> documentation has not been altered recently to make it this way then I'm
> inclined to keep the backward compatibility break. Your example uses a
> static method - you should be passing null and not the name of the class
> (this is also in the documentation).
>
>   [1]: http://php.net/manual/en/reflectionmethod.invoke.php

I have to disagree here.

Many codes out there uses string. What is the appealing reason to break
these codes in 7.1?

I think it should restore the precious behavior and if the docs need a
fix,  let fix it, not the other way.

Cheers
Pierre

--001a114133bc825319053aa9b293--