Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95382
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender)
To: internals@lists.php.net
References: <CAOWwgp=uAjaLm0gHCb6HFM+g0S=6itiOKZKk_u0Z4Mc_FimJeg@mail.gmail.com>
 <0b8ebd55-976b-f3a9-9f70-de392f2bd8e6@gmail.com>
 <aafeeeb5-95d6-eb04-9dd0-f79c270fd05f@gmx.de>
Message-ID: <168af9d7-e368-9d2e-a5fc-aa810279415d@gmail.com>
Date: Mon, 22 Aug 2016 16:44:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <aafeeeb5-95d6-eb04-9dd0-f79c270fd05f@gmx.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter1
 to be object, string given
From: rowan.collins@gmail.com (Rowan Collins)

On 22/08/2016 16:40, Christoph M. Becker wrote:
>> It is still ignored if it is a valid object, so the current beta's
>> > behaviour doesn't actually make a lot of sense.
> Well, see <https://3v4l.org/n8cad>.  Only as of 7.1.0beta3 ::invoke()
> matches the behavior of ::invokeArgs().

OK, so that's a further inconsistency. The current version still doesn't 
actually make sense, though. If you want to validate that the correct 
argument is being passed, then the only value allowed should be null.

> If so desired, I can revert that commit, but I wouldn't be happy with
> sticking with a completely unused parameter, which obviously has been
> and still is misunderstood.

The parameter is still unused, and can be any object. The only sane 
validation would be to check explicitly for null, which is documented as 
the correct argument for both invoke() and invokeArgs().

Regards,
-- 
Rowan Collins
[IMSoP]