Hi
with the php-src migrated to git we start receiving
pull request on github. A few things to notice:
- developers can pull the requests as described here:
https://wiki.php.net/vcs/gitfaq#github_pull_requests - people with valid github accounts can comment
on pull request - people with valid php accounts can close pull
request using the tool http://qa.php.net/pulls.
Thank you joahnnes for writing it.
Before pulling make sure:
- the pull request contains appropriate tests for
the change - the commit message contains a good and precise
description what was changed and why
ensure that you pull it into the right branch.
Pull request notifications are send to the
git-pulls@lists.php.net mailinglist.
Note that we DONT hand out access to the
github repository and will we not add
you to the PHP organization on github.
- David
Note that we DONT hand out access to the
github repository and will we not add
you to the PHP organization on github.
I think it would be a good idea to explain why are we (not) doing that.
AFAIR the reason is that if we hand out accounts on github, and somebody by
mistake merges the pull request there (instead of pulling it to git.php.net,
which will be automatically pushed to github) then our
github<->git.php.netclones will be out of sync, and that could/would
be a PITA to fix.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I think it would be a good idea to explain why are we (not) doing
that. AFAIR the reason is that if we hand out accounts on github,
and somebody by mistake merges the pull request there (instead of
pulling it to git.php.net, which will be automatically pushed to
github) then our github<->git.php.netclones will be out of sync,
and that could/would be a PITA to fix.
actually it will just be overwritten by the next push to git.php.net.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJPaF9fAAoJEAT0aMuPE7Z1JlkP/jZwHXLnL+VQgUPcSG20APlS
p8Hk5ieiILY1jR0qagugJQ17Jb8UVOPoAXdG4jSDS5qU4WavpYwwpMJ3G8HGXUyZ
k/ctm8VY+7z2aAzfXytj+/vL4GhNapB832X390IBmb6A/Icv8uVMOnLaXvGBRTYd
de//9H/Xglr4L2b99ulH0Ncqdgk9oRvkxcN6DgBU50H826lx19PIMsqGeNJzfP8n
lmRITysgKQWwmwZzvGtEeFyeZw724GC+0TnW9hfeXRDEsF7tXJ+QrY0G12GD3abO
6uSoRfC/wBJe//FyVHcoYzAcKHIMWyORUVEKch3Kr0xlxpkm5cyVcwKjV++rELkr
Mj3El8IidUZokYfiTSfTKagmCi6hxlS2y+bGO29CjlsFivgq7HQNc/QjckT8n/7p
mrklNsHDO/Fr6AelxCQzpF8TjNVS0RXNdB/XtsenXfZE1Zm/TwIpguxmXtc+ipoW
j1bCl0EdXM+3aM881CBnBhawzhrWjHcW5R+1yDOaRtk1mUs1W8ygIbLJRUXsCQkf
A7jTScwtrD0A7S88mVDg90dyuwtpA8d/4vfCFaByK0vW2MOm8DvPhbsin0DKbGJc
9zsHA+NXpsclza27t9pIaTYt8zxkyQWmRNslJ3vXzwHgcPmCfEpSu0KL3pAj36NW
ZjAhO77X0dafYTlwrWQA
=1/la
-----END PGP SIGNATURE
thanks dsp and johannes for this nice tool.
Hi
with the php-src migrated to git we start receiving
pull request on github. A few things to notice:- developers can pull the requests as described here:
https://wiki.php.net/vcs/gitfaq#github_pull_requests
- people with valid github accounts can comment
on pull request
- people with valid php accounts can close pull
request using the tool http://qa.php.net/pulls.
Thank you joahnnes for writing it.Before pulling make sure:
- the pull request contains appropriate tests for
the change
- the commit message contains a good and precise
description what was changed and whyensure that you pull it into the right branch.
Pull request notifications are send to the
git-pulls@lists.php.net mailinglist.Note that we DONT hand out access to the
github repository and will we not add
you to the PHP organization on github.- David
Quick clarification:
thanks dsp and johannes for this nice tool.
Hi
with the php-src migrated to git we start receiving
pull request on github. A few things to notice:
- developers can pull the requests as described here:
https://wiki.php.net/vcs/gitfaq#github_pull_requests- people with valid github accounts can comment
on pull request- people with valid php accounts can close pull
request using the tool http://qa.php.net/pulls.
Thank you joahnnes for writing it.Before pulling make sure:
- the pull request contains appropriate tests for
the change- the commit message contains a good and precise
description what was changed and whyensure that you pull it into the right branch.
Pull request notifications are send to the
git-pulls@lists.php.net mailinglist.Note that we DONT hand out access to the
github repository and will we not add
you to the PHP organization on github.
- David
--
--
Are you referring to "push" requests? I.e. are you talking about posting
commits you've made locally to the remote Git repo? If so, then in Git
this is referred to as a "push," not a "pull." I bring this up because, in
Git, a "pull" actually refers to something entirely different. A pull
refers to the exact opposite, in fact; i.e. using Git to "download" a
branch from a remote repo. In other words, you "pull" a branch from remote
to local, make your commits/merges/whatever, then "push" that branch back
up to the remote repo. If we start referring to pushes as pulls, that will
inevitably lead to a ton of unnecessary confusion.
On the other hand, by "pull request" are you simply referring to somebody
else requesting that you "pull" their submission and merge/push it? If so,
I get it, but I really think we should come up with another term to
describe it because it really does sound kinda backwards IMHO. I just woke
up less than an hour ago though so maybe I'm just groggy lol....
--Kris
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quick clarification: On the other hand, by "pull request" are you
simply referring to somebody else requesting that you "pull" their
submission and merge/push it? If so, I get it, but I really think
we should come up with another term to describe it because it
really does sound kinda backwards IMHO. I just woke up less than
an hour ago though so maybe I'm just groggy lol....
Drink a coffee wake up, think first and write the mail then and help
reducing mailinglist noise by trying to figure it out yourself.
We are referring to pull requests in the sense of pulling stuff from
another repository into ours. We talk about pull requests made on
github for the php/php-src repository. We use pull request the same
way everyone else uses. Someone requests via github or a pull request
mail (linux style) to pull his changes and merge them into our repository.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJPaL+6AAoJEAT0aMuPE7Z1QUEP/0eHx5TWk3EI2Y7RZPoBPZlT
2/uxGtc0ofAu2Tk+xEt0Avhbxoy9+gwlsXsDZK2aTYd3lfHoHQJ9YJfcsbIH7vWi
n08N0zI3uqeETyo/8W07KDIch6UGfEQaCgMDTDsAvIIJ7wLRCIYVuJEbAELdY1Xq
egBOBxSuEFie2k4P0GPnw92P0vf5orvMRwnIrIks26/OnxEpBlvC/bR2JQbfbHSy
qgJRP9KFV/rx8myvWPXhI6soNx1W8cuIiPgZY3ljslSjXJP5xiB88xzHIdnGk9KH
5q1H2XEZRt9TtLnOv0fxhvfgdPgxG2nD0UMo1Ucm/MJcDDaRA+hvlKpjNhAAx5qC
K4+Jtt4er0Q9D3lZW+vYY4lfpmADrTIN2UylFqm/9K1Tyn3t3aZPo1R9xxLH9mtX
JYRrZ2PZSWLdhQfZrPkJlVjkTZUCded/fEgr/3N4qjgoV+Yta4pw+XT1ccV8wMnG
tUy2RBaZloIsRObQ/JUps1SURYjDLAku+1eaPKeCcgkJnhF7fDgm6BJyfqqXg9c6
ci/Pg0K69UtzbLNpThZefU6WHCHdUUZKU8/cea4NX1vnpzW1orsTxbFLtxfYlxUq
eNTBQPeD7x0IGktF1uy5v+RGlpAEQQDgwEil3ovtjoNQ+XoAvDxeKtmhKzw0YmVF
vltnqeQggRED7abRzXxR
=W89T
-----END PGP SIGNATURE
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quick clarification: On the other hand, by "pull request" are you
simply referring to somebody else requesting that you "pull" their
submission and merge/push it? If so, I get it, but I really think
we should come up with another term to describe it because it
really does sound kinda backwards IMHO. I just woke up less than
an hour ago though so maybe I'm just groggy lol....Drink a coffee wake up, think first and write the mail then and help
reducing mailinglist noise by trying to figure it out yourself.We are referring to pull requests in the sense of pulling stuff from
another repository into ours. We talk about pull requests made on
github for the php/php-src repository. We use pull request the same
way everyone else uses. Someone requests via github or a pull request
mail (linux style) to pull his changes and merge them into our repository.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/iQIcBAEBAgAGBQJPaL+6AAoJEAT0aMuPE7Z1QUEP/0eHx5TWk3EI2Y7RZPoBPZlT
2/uxGtc0ofAu2Tk+xEt0Avhbxoy9+gwlsXsDZK2aTYd3lfHoHQJ9YJfcsbIH7vWi
n08N0zI3uqeETyo/8W07KDIch6UGfEQaCgMDTDsAvIIJ7wLRCIYVuJEbAELdY1Xq
egBOBxSuEFie2k4P0GPnw92P0vf5orvMRwnIrIks26/OnxEpBlvC/bR2JQbfbHSy
qgJRP9KFV/rx8myvWPXhI6soNx1W8cuIiPgZY3ljslSjXJP5xiB88xzHIdnGk9KH
5q1H2XEZRt9TtLnOv0fxhvfgdPgxG2nD0UMo1Ucm/MJcDDaRA+hvlKpjNhAAx5qC
K4+Jtt4er0Q9D3lZW+vYY4lfpmADrTIN2UylFqm/9K1Tyn3t3aZPo1R9xxLH9mtX
JYRrZ2PZSWLdhQfZrPkJlVjkTZUCded/fEgr/3N4qjgoV+Yta4pw+XT1ccV8wMnG
tUy2RBaZloIsRObQ/JUps1SURYjDLAku+1eaPKeCcgkJnhF7fDgm6BJyfqqXg9c6
ci/Pg0K69UtzbLNpThZefU6WHCHdUUZKU8/cea4NX1vnpzW1orsTxbFLtxfYlxUq
eNTBQPeD7x0IGktF1uy5v+RGlpAEQQDgwEil3ovtjoNQ+XoAvDxeKtmhKzw0YmVF
vltnqeQggRED7abRzXxR
=W89T
-----END PGP SIGNATURE-----
Yeah I get that. It just feels imprecise to me. Wouldn't "external merge
request" be more descriptive? Generally, a pull request refers to a pull
from a remote repository. While that's an initial component of this, the
fact that it ends with a push request just makes the terminology needlessly
confusing IMHO. But if nobody else is bothered by it then I guess I'll
just have to suck it up lol.
--Kris
P.S. I don't drink coffee. Never been able to develop a taste for it.
That's really sad seeing as how I live in Seattle....
Kris,
"Pull request" is a generally accepted term, specially when it comes to
github: http://help.github.com/send-pull-requests/
Hugo Peixoto
website: http://hugopeixoto.net
On Tue, Mar 20, 2012 at 10:34 AM, David Soria Parra dsoria@gmx.net
wrote:-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quick clarification: On the other hand, by "pull request" are you
simply referring to somebody else requesting that you "pull" their
submission and merge/push it? If so, I get it, but I really think
we should come up with another term to describe it because it
really does sound kinda backwards IMHO. I just woke up less than
an hour ago though so maybe I'm just groggy lol....Drink a coffee wake up, think first and write the mail then and help
reducing mailinglist noise by trying to figure it out yourself.We are referring to pull requests in the sense of pulling stuff from
another repository into ours. We talk about pull requests made on
github for the php/php-src repository. We use pull request the same
way everyone else uses. Someone requests via github or a pull request
mail (linux style) to pull his changes and merge them into our
repository.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/iQIcBAEBAgAGBQJPaL+6AAoJEAT0aMuPE7Z1QUEP/0eHx5TWk3EI2Y7RZPoBPZlT
2/uxGtc0ofAu2Tk+xEt0Avhbxoy9+gwlsXsDZK2aTYd3lfHoHQJ9YJfcsbIH7vWi
n08N0zI3uqeETyo/8W07KDIch6UGfEQaCgMDTDsAvIIJ7wLRCIYVuJEbAELdY1Xq
egBOBxSuEFie2k4P0GPnw92P0vf5orvMRwnIrIks26/OnxEpBlvC/bR2JQbfbHSy
qgJRP9KFV/rx8myvWPXhI6soNx1W8cuIiPgZY3ljslSjXJP5xiB88xzHIdnGk9KH
5q1H2XEZRt9TtLnOv0fxhvfgdPgxG2nD0UMo1Ucm/MJcDDaRA+hvlKpjNhAAx5qC
K4+Jtt4er0Q9D3lZW+vYY4lfpmADrTIN2UylFqm/9K1Tyn3t3aZPo1R9xxLH9mtX
JYRrZ2PZSWLdhQfZrPkJlVjkTZUCded/fEgr/3N4qjgoV+Yta4pw+XT1ccV8wMnG
tUy2RBaZloIsRObQ/JUps1SURYjDLAku+1eaPKeCcgkJnhF7fDgm6BJyfqqXg9c6
ci/Pg0K69UtzbLNpThZefU6WHCHdUUZKU8/cea4NX1vnpzW1orsTxbFLtxfYlxUq
eNTBQPeD7x0IGktF1uy5v+RGlpAEQQDgwEil3ovtjoNQ+XoAvDxeKtmhKzw0YmVF
vltnqeQggRED7abRzXxR
=W89T
-----END PGP SIGNATURE-----Yeah I get that. It just feels imprecise to me. Wouldn't "external merge
request" be more descriptive? Generally, a pull request refers to a pull
from a remote repository. While that's an initial component of this, the
fact that it ends with a push request just makes the terminology needlessly
confusing IMHO. But if nobody else is bothered by it then I guess I'll
just have to suck it up lol.--Kris
P.S. I don't drink coffee. Never been able to develop a taste for it.
That's really sad seeing as how I live in Seattle....
Yeah I know. That doesn't mean I have to like it though lol. ;P
--Kris
On Tue, Mar 20, 2012 at 12:11 PM, Hugo Peixoto hugo.peixoto@gmail.comwrote:
Kris,
"Pull request" is a generally accepted term, specially when it comes to
github: http://help.github.com/send-pull-requests/Hugo Peixoto
website: http://hugopeixoto.net
On Tue, Mar 20, 2012 at 10:34 AM, David Soria Parra dsoria@gmx.net
wrote:-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quick clarification: On the other hand, by "pull request" are you
simply referring to somebody else requesting that you "pull" their
submission and merge/push it? If so, I get it, but I really think
we should come up with another term to describe it because it
really does sound kinda backwards IMHO. I just woke up less than
an hour ago though so maybe I'm just groggy lol....Drink a coffee wake up, think first and write the mail then and help
reducing mailinglist noise by trying to figure it out yourself.We are referring to pull requests in the sense of pulling stuff from
another repository into ours. We talk about pull requests made on
github for the php/php-src repository. We use pull request the same
way everyone else uses. Someone requests via github or a pull request
mail (linux style) to pull his changes and merge them into our
repository.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/iQIcBAEBAgAGBQJPaL+6AAoJEAT0aMuPE7Z1QUEP/0eHx5TWk3EI2Y7RZPoBPZlT
2/uxGtc0ofAu2Tk+xEt0Avhbxoy9+gwlsXsDZK2aTYd3lfHoHQJ9YJfcsbIH7vWi
n08N0zI3uqeETyo/8W07KDIch6UGfEQaCgMDTDsAvIIJ7wLRCIYVuJEbAELdY1Xq
egBOBxSuEFie2k4P0GPnw92P0vf5orvMRwnIrIks26/OnxEpBlvC/bR2JQbfbHSy
qgJRP9KFV/rx8myvWPXhI6soNx1W8cuIiPgZY3ljslSjXJP5xiB88xzHIdnGk9KH
5q1H2XEZRt9TtLnOv0fxhvfgdPgxG2nD0UMo1Ucm/MJcDDaRA+hvlKpjNhAAx5qC
K4+Jtt4er0Q9D3lZW+vYY4lfpmADrTIN2UylFqm/9K1Tyn3t3aZPo1R9xxLH9mtX
JYRrZ2PZSWLdhQfZrPkJlVjkTZUCded/fEgr/3N4qjgoV+Yta4pw+XT1ccV8wMnG
tUy2RBaZloIsRObQ/JUps1SURYjDLAku+1eaPKeCcgkJnhF7fDgm6BJyfqqXg9c6
ci/Pg0K69UtzbLNpThZefU6WHCHdUUZKU8/cea4NX1vnpzW1orsTxbFLtxfYlxUq
eNTBQPeD7x0IGktF1uy5v+RGlpAEQQDgwEil3ovtjoNQ+XoAvDxeKtmhKzw0YmVF
vltnqeQggRED7abRzXxR
=W89T
-----END PGP SIGNATURE-----Yeah I get that. It just feels imprecise to me. Wouldn't "external merge
request" be more descriptive? Generally, a pull request refers to a pull
from a remote repository. While that's an initial component of this, the
fact that it ends with a push request just makes the terminology
needlessly
confusing IMHO. But if nobody else is bothered by it then I guess I'll
just have to suck it up lol.--Kris
P.S. I don't drink coffee. Never been able to develop a taste for it.
That's really sad seeing as how I live in Seattle....
Hi!
Yeah I know. That doesn't mean I have to like it though lol. ;P
You may like it or not like it, but it's established terminology so
we're going to use it. Let's not add noise to our lists.
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
On Tue, Mar 20, 2012 at 12:56 PM, Stas Malyshev smalyshev@sugarcrm.comwrote:
Hi!
Yeah I know. That doesn't mean I have to like it though lol. ;P
You may like it or not like it, but it's established terminology so
we're going to use it. Let's not add noise to our lists.Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
If we don't critically re-examine "established" ideas now and then, who
will? You can disagree with me, but please don't belittle other people's
concerns by dismissing them as "noise." I raised a legitimate concern that
was not "unworthy" of discussion. Just because I hold a minority viewpoint
doesn't make it any less valid and I stand by my posts. Ironically, your
dismissive comment after the fact only increased the "noise" factor by at
least two more posts.
I believe that the majority, including Github, is wrong on this. That term
is needlessly confusing in my opinion. I made that point and it didn't
gain any traction, so like I said I'll just have to suck it up and move
on. But if you're going to jump in with a, "We're gonna do it this way so
shut up," then all that's going to do is create animosity and drag this out
since obviously I"m not about to let such a comment go unchallenged. ;P
If you want to keep beating this dead horse, I'm game. Otherwise, all the
arguments have already been made so just let it go. I voiced my concern
and the majority doesn't share it, so that's that. Time to move on.
--Kris
On Tue, Mar 20, 2012 at 12:56 PM, Stas Malyshev <smalyshev@sugarcrm.com
wrote:
Hi!
Yeah I know. That doesn't mean I have to like it though lol. ;P
You may like it or not like it, but it's established terminology so
we're going to use it. Let's not add noise to our lists.Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227If we don't critically re-examine "established" ideas now and then, who
will?
please go with that problem to github, we didn't coined that term, so we
can't really fix it for you.
You can disagree with me, but please don't belittle other people's
concerns by dismissing them as "noise."
it is noise on this mailing list, as this isn't the place to fix that term,
even if you are right.
I raised a legitimate concern that
was not "unworthy" of discussion. Just because I hold a minority viewpoint
doesn't make it any less valid and I stand by my posts. Ironically, your
dismissive comment after the fact only increased the "noise" factor by at
least two more posts.
the thing is that it wasn't your first or second post which regulars would
count as noise, so this time somebody mentioned that you shouldn't do that.
I believe that the majority, including Github, is wrong on this.
yeah, but how can you fix that with lecturing people here?
That term
is needlessly confusing in my opinion. I made that point and it didn't
gain any traction, so like I said I'll just have to suck it up and move
on. But if you're going to jump in with a, "We're gonna do it this way so
shut up," then all that's going to do is create animosity and drag this out
since obviously I"m not about to let such a comment go unchallenged. ;P
sigh.
If you want to keep beating this dead horse, I'm game. Otherwise, all the
arguments have already been made so just let it go. I voiced my concern
and the majority doesn't share it, so that's that. Time to move on.
\o/
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
On Tue, Mar 20, 2012 at 12:56 PM, Stas Malyshev <smalyshev@sugarcrm.com
wrote:
Hi!
Yeah I know. That doesn't mean I have to like it though lol. ;P
You may like it or not like it, but it's established terminology so
we're going to use it. Let's not add noise to our lists.Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227If we don't critically re-examine "established" ideas now and then, who
will?please go with that problem to github, we didn't coined that term, so we
can't really fix it for you.You can disagree with me, but please don't belittle other people's
concerns by dismissing them as "noise."it is noise on this mailing list, as this isn't the place to fix that
term, even if you are right.I raised a legitimate concern that
was not "unworthy" of discussion. Just because I hold a minority
viewpoint
doesn't make it any less valid and I stand by my posts. Ironically, your
dismissive comment after the fact only increased the "noise" factor by at
least two more posts.the thing is that it wasn't your first or second post which regulars would
count as noise, so this time somebody mentioned that you shouldn't do that.I believe that the majority, including Github, is wrong on this.
yeah, but how can you fix that with lecturing people here?
That term
is needlessly confusing in my opinion. I made that point and it didn't
gain any traction, so like I said I'll just have to suck it up and move
on. But if you're going to jump in with a, "We're gonna do it this way so
shut up," then all that's going to do is create animosity and drag this
out
since obviously I"m not about to let such a comment go unchallenged. ;Psigh.
If you want to keep beating this dead horse, I'm game. Otherwise, all the
arguments have already been made so just let it go. I voiced my concern
and the majority doesn't share it, so that's that. Time to move on.\o/
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
The horse is already dead. Why are you still wacking it with a stick?
Last time I checked, the PHP Group doesn't take orders from Github. We
have the power to use whatever internal terminology we damn well please
with or without their permission. But again, why do you insist on
resurrecting this dead discussion?? I've already acknowledged repeatedly
that I'm in the minority on this one. But just because you and a few other
stuffed shirts don't understand the value of dissenting viewpoints, that
doesn't mean that said dissent amounts to "noise." Maybe some people here
aren't accustomed to having their edicts challenged. Either way, I've
noticed a consistent pattern of dissenting views being clamped-down and
summarily dismissed in the same manner; that is, in part, what prompted me
to become more active on here to begin with. I.e. because I'm accustomed
to dealing with a tough room. I'm a liberal intellectual in the U.S., so
being in the oft-dismissed and shouted-down minority is something I am very
much used to. =)
But seriously, the discussion on the terminology has already ended.
Everything has been said. I don't like the choice that the majority has
made but I'll just have to live with it. I made my suggestion, presented
my argument, and this time it just didn't have legs. You win some, you
lose some; I'm ok with that. I still believe a more accurate term would be
better but I've already moved on. It's time for you to do the same and let
it go. You're not accomplishing anything by continuing to drag this out.
Let the dead horse rest in peace.
--Kris
The horse is already dead. Why are you still wacking it with a stick?
that was my first and only reply to you about this issue, and this will be
my last one, I promise.
Last time I checked, the PHP Group doesn't take orders from Github.
we don't, my point was that if you really want to fix that terminology
"issue", it would make more sense to complain at the source.
as you have seen and said yourself, most people around here are familiar
with the term, so there is no confusion to be fixed here.
We have the power to use whatever internal terminology we damn well
please with or without their permission.
sure, you can, as github also had that option, and it seems that their
terminology got more traction than yours.
But again, why do you insist on resurrecting this dead discussion??
that's redundant, see above.
I've already acknowledged repeatedly that I'm in the minority on this
one.
yeah, and in this very same mail you still questioning why should we use
the generally accepted term, so?
But just because you and a few other stuffed shirts don't understand the
value of dissenting viewpoints,
that's so nice of you
that doesn't mean that said dissent amounts to "noise."
your mail didn't really added anything valuable, got called out as noise,
it happens.
Maybe some people here aren't accustomed to having their edicts challenged.
nah, thanks to you and a few other folks those people are constantly
practicing to endure that.
Either way, I've noticed a consistent pattern of dissenting views being
clamped-down and summarily dismissed in the same manner; that is, in part,
what prompted me to become more active on here to begin with. I.e. because
I'm accustomed to dealing with a tough room. I'm a liberal intellectual in
the U.S., so being in the oft-dismissed and shouted-down minority is
something I am very much used to. =)
the idea never occured to you that maybe there is some connection between
your attitude and those "tough rooms" and "stuffed shirts" that you see
everywhere?
But seriously, the discussion on the terminology has already ended.
Everything has been said. I don't like the choice that the majority has
made but I'll just have to live with it.
hurray
I made my suggestion, presented my argument, and this time it just
didn't have legs.
which is a good thing, and appreciated.
You win some, you lose some; I'm ok with that. I still believe a more
accurate term would be better but I've already moved on. It's time for you
to do the same and let it go. You're not accomplishing anything by
continuing to drag this out. Let the dead horse rest in peace.
let's do that.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
The horse is already dead. Why are you still wacking it with a stick?
that was my first and only reply to you about this issue, and this will be
my last one, I promise.
I was referring to you guys piling on as a group. Try not to take it so
personally.
Last time I checked, the PHP Group doesn't take orders from Github.
we don't, my point was that if you really want to fix that terminology
"issue", it would make more sense to complain at the source.
as you have seen and said yourself, most people around here are familiar
with the term, so there is no confusion to be fixed here.
It's not a question of awareness. It's just an ill-thought term to begin
with. It's inaccurate and vague. I'm trying to make things as easy as
possible for Subversion folks switching over to Git without too much
confusion. At very least, the "noise" from this little thread should
mitigate that.
Perhaps it was wrong of me to think that we should actually take the lead
and set a good example on something that needs to be fixed. Oh well.
We have the power to use whatever internal terminology we damn well
please with or without their permission.sure, you can, as github also had that option, and it seems that their
terminology got more traction than yours.
You're just regurgitating what I've already said ad nauseum. But again,
the majority view isn't always the right view. You should try to be
mindful of that when evaluating new ideas.
But again, why do you insist on resurrecting this dead discussion??
that's redundant, see above.
Of course it is. Like I said, everything has already been said. That
breeds redundancy. Stop bringing up the same points and the redundancy
will cease lol.
I've already acknowledged repeatedly that I'm in the minority on this
one.yeah, and in this very same mail you still questioning why should we use
the generally accepted term, so?
That's right. You don't seem to understand the difference between
deference and conformance. I deferred to the majority opinion since
there's really no point in trying to jam my view down other people's
throats, but that does not mean that I decided to conform my views to match
yours. I've made it clear that, while my opinion has not changed, I've
decided this one just isn't worth fighting over. Of course, the irony is
that you guys are prolonging this fight needlessly by continuing to pile on
with stuff that has already been said.
But just because you and a few other stuffed shirts don't understand the
value of dissenting viewpoints,that's so nice of you
You're welcome.
that doesn't mean that said dissent amounts to "noise."
your mail didn't really added anything valuable, got called out as noise,
it happens.
In your opinion. But just because something has no value for you doesn't
mean that it has no value period. That's the sort of arrogant posturing
that causes these flamewars to begin with. One would think you guys who
engage in this behavior would have learned from that by now.
Maybe some people here aren't accustomed to having their edicts
challenged.nah, thanks to you and a few other folks those people are constantly
practicing to endure that.
Keep practicing.
Either way, I've noticed a consistent pattern of dissenting views being
clamped-down and summarily dismissed in the same manner; that is, in part,
what prompted me to become more active on here to begin with. I.e. because
I'm accustomed to dealing with a tough room. I'm a liberal intellectual in
the U.S., so being in the oft-dismissed and shouted-down minority is
something I am very much used to. =)the idea never occured to you that maybe there is some connection between
your attitude and those "tough rooms" and "stuffed shirts" that you see
everywhere?
Lol have you ever visited the U.S.? I've had roomfuls of people scream
bloody murder (literally) for daring to suggest that an egg that was just
penetrated by a sperm cell is not equivalent to a human baby. I've had
people call me a terrorist sympathizer for suggesting that the proposed
invasion of Iraq might not be such a good idea (and boy was I wrong lol!).
I've gotten into shouting matches trying to explain to protesters why their
signs that said, "Keep your government hands off my Medicare!" made no
sense.
Again, you seem to be embracing the logical fallacy that, if the majority
is hostile to your views, then your views must be wrong.
But seriously, the discussion on the terminology has already ended.
Everything has been said. I don't like the choice that the majority has
made but I'll just have to live with it.hurray
You're really slow on the uptake, considering I'd already said that several
times lol.
I made my suggestion, presented my argument, and this time it just
didn't have legs.which is a good thing, and appreciated.
If you had just said that and left it alone, we wouldn't still be rehashing
it. ;P
You win some, you lose some; I'm ok with that. I still believe a more
accurate term would be better but I've already moved on. It's time for you
to do the same and let it go. You're not accomplishing anything by
continuing to drag this out. Let the dead horse rest in peace.let's do that.
I'm glad you finally agree.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
Hi Kris,
But just because you and a few other stuffed shirts don't understand
the
value of dissenting viewpoints,that's so nice of you
You're welcome.
Your tone and argumentative style in recent posts is really not helpful to
your cause.
Please try to keep discussions on this list civil and technical.
Often emotion and other biases do appear. It's much better to ignore them
and keep focused on the true issues, than to address them - no matter how
calmly worded or light-hearted your response may be.
I.E. Let's have a technical debate not a pissing contest ;)
Regards,
Arpad
Arpad,
Hi Kris,
But just because you and a few other stuffed shirts don't understand
the
value of dissenting viewpoints,that's so nice of you
You're welcome.
Your tone and argumentative style in recent posts is really not helpful to
your cause.Please try to keep discussions on this list civil and technical.
Often emotion and other biases do appear. It's much better to ignore them
and keep focused on the true issues, than to address them - no matter how
calmly worded or light-hearted your response may be.I.E. Let's have a technical debate not a pissing contest ;)
Regards,
Arpad
You're absolutely right. Generally speaking, when somebody delivers a
witlessly sarcastic remark like, "that's so nice of you," or, "thank you
for being a dick," my default reply is, "You're welcome." It falls under
the principle of beating them at their own game; fighting fire with fire,
as it were.
But you're correct in that I need to be careful not to allow my zeal for
putting bullies in their place go too far and start annoying people who
don't actually deserve to be annoyed. It's a delicate balance and letting
emotion into the equation really doesn't help. I'll try to be more mindful
of that.
He definitely had that, "you're welcome," response coming to him after his
sardonic little jab, but that alone doesn't mean it was necessary. I allow
myself to be a bit hypersensitive when I perceive an environment where
people with dissenting views are being bullied into silence, which I
believe for some time now has been the case on this list. I.e. I hit back
to set an example and level the playing field a little. But even so,
sometimes I get a bit carried away. I probably could have safely ignored
some of Ferenc's juvenile remarks while still sufficiently pushing back
against this latest anti-dissent gangbang.
Thanks for the reminder! If it ever looks like I'm getting carried away
while standing up to these guys, please don't be afraid to let me know. =)
--Kris
Thanks for the reminder! If it ever looks like I'm getting carried away
while standing up to these guys, please don't be afraid to let me know.
I hate to even get involved in this thread, but [especially] now that the issue is resolved, could you please start replying to people in private instead of to the list? I suspect that most subscribers simply don't care about who gets the last word in this conversation.
(note: I'm only replying to the list (and not in private) because I think it applies to others involved in this conversation, and to so many other conversations on this list)
Thank you.
S
--f46d043892b5d6413304bbb15eed
Content-Type: text/plain; charset=ISO-8859-1-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quick clarification: On the other hand, by "pull request" are you
simply referring to somebody else requesting that you "pull" their
submission and merge/push it? If so, I get it, but I really think
we should come up with another term to describe it because it
really does sound kinda backwards IMHO. I just woke up less than
an hour ago though so maybe I'm just groggy lol....Drink a coffee wake up, think first and write the mail then and help
reducing mailinglist noise by trying to figure it out yourself.We are referring to pull requests in the sense of pulling stuff from
another repository into ours. We talk about pull requests made on
github for the php/php-src repository. We use pull request the same
way everyone else uses. Someone requests via github or a pull request
mail (linux style) to pull his changes and merge them into our repository.Yeah I get that. It just feels imprecise to me. Wouldn't "external merge
request" be more descriptive? Generally, a pull request refers to a pull
from a remote repository. While that's an initial component of this, the
fact that it ends with a push request just makes the terminology needlessly
confusing IMHO. But if nobody else is bothered by it then I guess I'll
just have to suck it up lol.
This is how the general population of git users understands it; I don't
see any reason to introduce additional terminology.
--
Matthew Weier O'Phinney
Project Lead | matthew@zend.com
Zend Framework | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc