Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59078
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <slrnjmgm8f.mfm.dsp@experimentalworks.net>
References: <slrnjmgm8f.mfm.dsp@experimentalworks.net>
Date: Tue, 20 Mar 2012 14:11:03 +0000
Message-ID: <CAKxcST_VqXXaxHvLhnxd6ata-RMboF4kCZzCSRdQJQF0hWRZkw@mail.gmail.com>
To: David Soria Parra <dsp@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Github Pull Request
From: dragoonis@gmail.com (Paul Dragoonis)

thanks dsp and johannes for this nice tool.

On Tue, Mar 20, 2012 at 10:16 AM, David Soria Parra <dsp@php.net> wrote:
> Hi
>
> with the php-src migrated to git we start receiving
> pull request on github. A few things to notice:
>
> =A0- developers can pull the requests as described here:
> =A0 =A0https://wiki.php.net/vcs/gitfaq#github_pull_requests
> =A0- people with valid github accounts can comment
> =A0 =A0on pull request
> =A0- people with valid php accounts can close pull
> =A0 =A0request using the tool http://qa.php.net/pulls.
> =A0 =A0Thank you joahnnes for writing it.
>
> Before pulling make sure:
>
> =A0- the pull request contains appropriate tests for
> =A0 =A0the change
> =A0- the commit message contains a good and precise
> =A0 =A0description what was changed and why
>
> ensure that you pull it into the right branch.
>
> Pull request notifications are send to the
> git-pulls@lists.php.net mailinglist.
>
> Note that we DONT hand out access to the
> github repository and will we not add
> you to the PHP organization on github.
>
> =A0- David
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>