Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59081
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAKxcST_VqXXaxHvLhnxd6ata-RMboF4kCZzCSRdQJQF0hWRZkw@mail.gmail.com>
References: <slrnjmgm8f.mfm.dsp@experimentalworks.net>
	<CAKxcST_VqXXaxHvLhnxd6ata-RMboF4kCZzCSRdQJQF0hWRZkw@mail.gmail.com>
Date: Tue, 20 Mar 2012 10:29:00 -0700
Message-ID: <CAKOpQSykJTJbiwCh7Y3FJsM5LAp1sCgK4W33et8jzsMWbsv1fA@mail.gmail.com>
To: Paul Dragoonis <dragoonis@gmail.com>
Cc: David Soria Parra <dsp@php.net>, internals@lists.php.net
Content-Type: multipart/alternative; boundary=f46d043892abb50e1a04bbb002c9
Subject: Re: [PHP-DEV] Github Pull Request
From: kris.craig@gmail.com (Kris Craig)

--f46d043892abb50e1a04bbb002c9
Content-Type: text/plain; charset=ISO-8859-1

Quick clarification:

On Tue, Mar 20, 2012 at 7:11 AM, Paul Dragoonis <dragoonis@gmail.com> wrote:

> thanks dsp and johannes for this nice tool.
>
> On Tue, Mar 20, 2012 at 10:16 AM, David Soria Parra <dsp@php.net> wrote:
> > Hi
> >
> > with the php-src migrated to git we start receiving
> > pull request on github. A few things to notice:
> >
> >  - developers can pull the requests as described here:
> >    https://wiki.php.net/vcs/gitfaq#github_pull_requests
> >  - people with valid github accounts can comment
> >    on pull request
> >  - people with valid php accounts can close pull
> >    request using the tool http://qa.php.net/pulls.
> >    Thank you joahnnes for writing it.
> >
> > Before pulling make sure:
> >
> >  - the pull request contains appropriate tests for
> >    the change
> >  - the commit message contains a good and precise
> >    description what was changed and why
> >
> > ensure that you pull it into the right branch.
> >
> > Pull request notifications are send to the
> > git-pulls@lists.php.net mailinglist.
> >
> > Note that we DONT hand out access to the
> > github repository and will we not add
> > you to the PHP organization on github.
> >
> >  - David
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Are you referring to "push" requests?  I.e. are you talking about posting
commits you've made locally to the remote Git repo?  If so, then in Git
this is referred to as a "push," not a "pull."  I bring this up because, in
Git, a "pull" actually refers to something entirely different.  A pull
refers to the exact opposite, in fact; i.e. using Git to "download" a
branch from a remote repo.  In other words, you "pull" a branch from remote
to local, make your commits/merges/whatever, then "push" that branch back
up to the remote repo.  If we start referring to pushes as pulls, that will
inevitably lead to a ton of unnecessary confusion.

On the other hand, by "pull request" are you simply referring to somebody
else requesting that you "pull" their submission and merge/push it?  If so,
I get it, but I really think we should come up with another term to
describe it because it really does sound kinda backwards IMHO.  I just woke
up less than an hour ago though so maybe I'm just groggy lol....

--Kris

--f46d043892abb50e1a04bbb002c9--