Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59083
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F68BFBA.1050605@gmx.net>
References: <slrnjmgm8f.mfm.dsp@experimentalworks.net>
	<CAKxcST_VqXXaxHvLhnxd6ata-RMboF4kCZzCSRdQJQF0hWRZkw@mail.gmail.com>
	<CAKOpQSykJTJbiwCh7Y3FJsM5LAp1sCgK4W33et8jzsMWbsv1fA@mail.gmail.com>
	<4F68BFBA.1050605@gmx.net>
Date: Tue, 20 Mar 2012 12:06:21 -0700
Message-ID: <CAKOpQSzS-pAxJ_WpU7sWru8aGA712RcL5Ky0UCsuFSDp8S_u5g@mail.gmail.com>
To: David Soria Parra <dsoria@gmx.net>
Cc: Paul Dragoonis <dragoonis@gmail.com>, David Soria Parra <dsp@php.net>, internals@lists.php.net
Content-Type: multipart/alternative; boundary=f46d043892b5d6413304bbb15eed
Subject: Re: [PHP-DEV] Github Pull Request
From: kris.craig@gmail.com (Kris Craig)

--f46d043892b5d6413304bbb15eed
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Mar 20, 2012 at 10:34 AM, David Soria Parra <dsoria@gmx.net> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 03/20/2012 06:29 PM, Kris Craig wrote:
> > Quick clarification: On the other hand, by "pull request" are you
> > simply referring to somebody else requesting that you "pull" their
> > submission and merge/push it?  If so, I get it, but I really think
> > we should come up with another term to describe it because it
> > really does sound kinda backwards IMHO.  I just woke up less than
> > an hour ago though so maybe I'm just groggy lol....
>
> Drink a coffee wake up, think first and write the mail then and help
> reducing mailinglist noise by trying to figure it out yourself.
>
> We are referring to pull requests in the sense of pulling stuff from
> another repository into ours. We talk about pull requests made on
> github for the php/php-src repository. We use pull request the same
> way everyone else uses. Someone requests via github or a pull request
> mail (linux style) to pull his changes and merge them into our repository.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQIcBAEBAgAGBQJPaL+6AAoJEAT0aMuPE7Z1QUEP/0eHx5TWk3EI2Y7RZPoBPZlT
> 2/uxGtc0ofAu2Tk+xEt0Avhbxoy9+gwlsXsDZK2aTYd3lfHoHQJ9YJfcsbIH7vWi
> n08N0zI3uqeETyo/8W07KDIch6UGfEQaCgMDTDsAvIIJ7wLRCIYVuJEbAELdY1Xq
> egBOBxSuEFie2k4P0GPnw92P0vf5orvMRwnIrIks26/OnxEpBlvC/bR2JQbfbHSy
> qgJRP9KFV/rx8myvWPXhI6soNx1W8cuIiPgZY3ljslSjXJP5xiB88xzHIdnGk9KH
> 5q1H2XEZRt9TtLnOv0fxhvfgdPgxG2nD0UMo1Ucm/MJcDDaRA+hvlKpjNhAAx5qC
> K4+Jtt4er0Q9D3lZW+vYY4lfpmADrTIN2UylFqm/9K1Tyn3t3aZPo1R9xxLH9mtX
> JYRrZ2PZSWLdhQfZrPkJlVjkTZUCded/fEgr/3N4qjgoV+Yta4pw+XT1ccV8wMnG
> tUy2RBaZloIsRObQ/JUps1SURYjDLAku+1eaPKeCcgkJnhF7fDgm6BJyfqqXg9c6
> ci/Pg0K69UtzbLNpThZefU6WHCHdUUZKU8/cea4NX1vnpzW1orsTxbFLtxfYlxUq
> eNTBQPeD7x0IGktF1uy5v+RGlpAEQQDgwEil3ovtjoNQ+XoAvDxeKtmhKzw0YmVF
> vltnqeQggRED7abRzXxR
> =W89T
> -----END PGP SIGNATURE-----
>

Yeah I get that.  It just feels imprecise to me.  Wouldn't "external merge
request" be more descriptive?  Generally, a pull request refers to a pull
from a remote repository.  While that's an initial component of this, the
fact that it ends with a push request just makes the terminology needlessly
confusing IMHO.  But if nobody else is bothered by it then I guess I'll
just have to suck it up lol.

--Kris

P.S. I don't drink coffee.  Never been able to develop a taste for it.
That's really sad seeing as how I live in Seattle....

--f46d043892b5d6413304bbb15eed--