Den lør. 4. maj 2019 kl. 14.19 skrev Christoph M. Becker email@example.com:
I have submitted PR #4112 to bring back the common PDO tests, which are
the majority of existing tests for pdo_firebird. Three tests are
failing (which should be investigated), but these tests already failed
in PHP-7.3 and maybe before.
I had a look at your PRs, both look good! Like I mentioned on the
common.phpt one, I wasn't aware of this PDO magic, so its good that
you fixed it quickly.
+1 on both PRs.
I had a closer look at the tests failing with Firebird 126.96.36.199054 (x64):
bug_69356.phpt fails because FB doesn't support
SELECT expr; queries;
apparently, a FROM clause would be required.
If that is the case, we should add the FROM clause. When I tested it,
it was passing but I'm uncertain how exactly. I was using a 3.0.2 x64
build on Windows for these, so there seems to be something odd going
bug_71447.phpt fails because there are issues regarding comments with a
Could this be an SQL dialect setting missing given its pass for me?
bug_73234.phpt fails because FB doesn't support defining explicit
nullable columns, i.e.
CREATE TABLE (id INT NULL)
is unsupported. Removing the
NULL let's the test proceed, but binding a
zero as PDO::PARAM_NULL apparently inserts
string(1) "0" which looks
like a bug in the driver.
Again odd it did not fail for me, but we should log a bug about this
issue if there isn't one already and hope that someone will pick it up
unless you want to invest the time into it.
Thanks for looking into these! Much appreciated.
Kalle Sommer Nielsen