Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105585
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Lester <lester@lsces.co.uk>, Internals <internals@lists.php.net>
References: <CAJW__o0KnY=gcLD+vyX1M3HeirUm+UHYh05+nqkpRBefriq3Hg@mail.gmail.com>
 <CAJW__o26mt-REVVgL1OR-cWA7LSfxee3H2Yi2W6qaU1SjP=ujA@mail.gmail.com>
 <6cc22608-d4b2-e7f4-d534-f4b5f02bc3d2@gmx.de>
 <CAJW__o3CoRWWMAtsEWGSHYrcXFnvc9NFo3Ra49+MBwBCbuafjQ@mail.gmail.com>
 <59d0e63c-7e78-be96-f9a2-1f2505393017@gmx.de>
 <CAJW__o3b9w9SQVEBYffgUpGB0j4GBuevZQdqC86UQmQFi_netQ@mail.gmail.com>
 <52a401b8-99b7-94ce-2885-8c1329e9d4d4@lsces.co.uk>
 <CAJW__o3-7er6+inVtTGhwAhPtAzHH8KAmqp1-joxW2fzq1tUVw@mail.gmail.com>
 <bbe87fe0-05f3-7c56-5467-9099b6eb51b3@gmx.de>
 <CAJW__o2gcxEqAMZDGho44t--EW7P-jz3nmgJyL+52zPtNqRXoQ@mail.gmail.com>
Message-ID: <33eaa086-e411-c8fb-cd44-127e4b769046@gmx.de>
Date: Sat, 4 May 2019 10:56:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAJW__o2gcxEqAMZDGho44t--EW7P-jz3nmgJyL+52zPtNqRXoQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Kalle!

On 03.05.2019 at 19:00, Kalle Sommer Nielsen wrote:

> Den fre. 3. maj 2019 kl. 12.02 skrev Christoph M. Becker <cmbecker69@gmx=
.de>:
>
>> While running the tests with a PHP debug version, I've noticed that
>> bug_aaa.phpt is causing a memory leak.  Maybe someone proficient with
>> Firebird/Interbase will want to have a look at it.
>
> Thank you for testing, good to know that they at least run there too!

ACK.  It would be even nicer to have these tests run on a CI, though.

> As for the memory leak, perhaps we should mark the relevant test with
> an --XFAIL-- or something? The name was suspicious in the first place.

The respective commit message[1] explains the test name; it is about a
fix for an unfiled bug, so instead of a concrete bug number the suffix
"aaa" had been chosen.

Anyhow, I have submitted PR #4111 which would fix the memory leak.  I'm
not 100% sure that this couldn't cause a UAF scenario, though, so I have
targeted PHP-7.4 for now.

> Guess this is as good as it gets for PDO_Firebird at least.

I have submitted PR #4112 to bring back the common PDO tests, which are
the majority of existing tests for pdo_firebird.  Three tests are
failing (which should be investigated), but these tests already failed
in PHP-7.3 and maybe before.

[1]
<http://git.php.net/?p=3Dphp-src.git;a=3Dcommit;h=3Dcf46ac1179376f58895feb=
6ed914b03bea19e295>
[2] <https://github.com/php/php-src/pull/4111>
[3] <https://github.com/php/php-src/pull/4112>

=2D-
Christoph M. Becker