Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105587
MIME-Version: 1.0
References: <CAJW__o0KnY=gcLD+vyX1M3HeirUm+UHYh05+nqkpRBefriq3Hg@mail.gmail.com>
 <CAJW__o26mt-REVVgL1OR-cWA7LSfxee3H2Yi2W6qaU1SjP=ujA@mail.gmail.com>
 <6cc22608-d4b2-e7f4-d534-f4b5f02bc3d2@gmx.de> <CAJW__o3CoRWWMAtsEWGSHYrcXFnvc9NFo3Ra49+MBwBCbuafjQ@mail.gmail.com>
 <59d0e63c-7e78-be96-f9a2-1f2505393017@gmx.de> <CAJW__o3b9w9SQVEBYffgUpGB0j4GBuevZQdqC86UQmQFi_netQ@mail.gmail.com>
 <52a401b8-99b7-94ce-2885-8c1329e9d4d4@lsces.co.uk> <CAJW__o3-7er6+inVtTGhwAhPtAzHH8KAmqp1-joxW2fzq1tUVw@mail.gmail.com>
 <bbe87fe0-05f3-7c56-5467-9099b6eb51b3@gmx.de> <CAJW__o2gcxEqAMZDGho44t--EW7P-jz3nmgJyL+52zPtNqRXoQ@mail.gmail.com>
 <33eaa086-e411-c8fb-cd44-127e4b769046@gmx.de> <c875088c-ef28-35cd-bc84-4a9984683f3b@gmx.de>
In-Reply-To: <c875088c-ef28-35cd-bc84-4a9984683f3b@gmx.de>
Date: Sat, 4 May 2019 14:33:05 +0300
Message-ID: <CAJW__o3HeLi2OJJ6C531Wt=mnw5NDfhet6P1=T0aCEDZQZHYWg@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Lester <lester@lsces.co.uk>, Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Christoph

Den l=C3=B8r. 4. maj 2019 kl. 14.19 skrev Christoph M. Becker <cmbecker69@g=
mx.de>:
>
> On 04.05.2019 at 10:56, Christoph M. Becker wrote:
>
> > I have submitted PR #4112 to bring back the common PDO tests, which are
> > the majority of existing tests for pdo_firebird.  Three tests are
> > failing (which should be investigated), but these tests already failed
> > in PHP-7.3 and maybe before.

I had a look at your PRs, both look good! Like I mentioned on the
common.phpt one, I wasn't aware of this PDO magic, so its good that
you fixed it quickly.

+1 on both PRs.

> I had a closer look at the tests failing with Firebird 3.0.4.33054 (x64):
>
> bug_69356.phpt fails because FB doesn't support `SELECT expr;` queries;
> apparently, a FROM clause would be required.

If that is the case, we should add the FROM clause. When I tested it,
it was passing but I'm uncertain how exactly. I was using a 3.0.2 x64
build on Windows for these, so there seems to be something odd going
on here.

> bug_71447.phpt fails because there are issues regarding comments with a
> single quote.

Could this be an SQL dialect setting missing given its pass for me?

> bug_73234.phpt fails because FB doesn't support defining explicit
> nullable columns, i.e.
>
>   CREATE TABLE (id INT NULL)
>
> is unsupported.  Removing the NULL let's the test proceed, but binding a
> zero as PDO::PARAM_NULL apparently inserts `string(1) "0"` which looks
> like a bug in the driver.

Again odd it did not fail for me, but we should log a bug about this
issue if there isn't one already and hope that someone will pick it up
unless you want to invest the time into it.

Thanks for looking into these! Much appreciated.

--=20
regards,

Kalle Sommer Nielsen
kalle@php.net