Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105560
MIME-Version: 1.0
References: <CAJW__o0KnY=gcLD+vyX1M3HeirUm+UHYh05+nqkpRBefriq3Hg@mail.gmail.com>
 <CAJW__o26mt-REVVgL1OR-cWA7LSfxee3H2Yi2W6qaU1SjP=ujA@mail.gmail.com> <6cc22608-d4b2-e7f4-d534-f4b5f02bc3d2@gmx.de>
In-Reply-To: <6cc22608-d4b2-e7f4-d534-f4b5f02bc3d2@gmx.de>
Date: Thu, 2 May 2019 16:35:48 +0300
Message-ID: <CAJW__o3CoRWWMAtsEWGSHYrcXFnvc9NFo3Ra49+MBwBCbuafjQ@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [RFC VOTE] Unbundle ext/interbase
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Christoph

Den tor. 2. maj 2019 kl. 14.56 skrev Christoph M. Becker <cmbecker69@gmx.de>:
> A problem is that the ext/pdo_firebird tests rely on ext/interbase to
> create a test database[1], which would require everybody who intends to
> run these tests to install PECL/interbase package now.  It would be
> great if somebody would rewrite this, so interbase would no longer be a
> dependency of the pdo_firebird tests.
>
> [1] <https://github.com/php/php-src/blob/PHP-7.4/ext/pdo_firebird/tests
> /testdb.inc>

Yeah that is one thing that is kind of unfortunate and a bad practice.
However since interbase was disabled for AppVeyor, these tests had no
chance to run in a while. Looking at the actual code in testdb.inc, it
seems like it creates the database for testing purposes, I would
suppose this is due to PDO_Firebird perhaps requiring a database to
continue its connection flow in PDO itself.

I'm not sure how we can go about this, maybe a .sql file for testers
who run the test suite for schemas and then see if we can integrate
some auto importer in our CI build scripts for this special case? (In
the case we cannot go around PDO). Either way the test files requires
a manual touch to configure credentials to run.

I'm personally fine with the simple solution, thoughts?


(ps. Thanks for the fix for the AppVeyor part I missed)

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net