Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105561 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 31633 invoked from network); 2 May 2019 16:54:31 -0000 Received: from unknown (HELO mout.gmx.net) (212.227.17.20) by pb1.pair.com with SMTP; 2 May 2019 16:54:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556805429; bh=DvnEvOnW+Q6+xoe7BOvU/PJfeTEhoANwr/T0i/yZ6mE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=OGPkhV5B34q4xv+qHeCQuYWDwsyCwy8szhoUpACjISkub+BFDHTqfEdHoemT61WYq aQtf4TybfmlLzGpCty5Xn1OScsjny7HKHKyiG16uqWS0+1RiNJA1iieyaZIDWHGsdF SV3caxT0X03lXlm0Y5iYAIXfCsAjTcKfoESRGHa8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.2.144] ([79.222.45.225]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LiWzQ-1gllWr2RsS-00ciqo; Thu, 02 May 2019 15:57:09 +0200 To: Kalle Sommer Nielsen Cc: Internals References: <6cc22608-d4b2-e7f4-d534-f4b5f02bc3d2@gmx.de> Message-ID: <59d0e63c-7e78-be96-f9a2-1f2505393017@gmx.de> Date: Thu, 2 May 2019 15:57:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:n+WWo6jSzm883RnhTFs0PckPn6t7LpYA8JPwzVF63fGlvm8VJJ7 F3F5pKwBlqkxo4quw0sXD3AP2H3jVuC4ii/vbjeN/oQqTOIm/fGKZG8yvqh2ZCU5V4nuCBk hpL3XxYjffg9WrZ4WoN8AvJ9Kd0WuylG0MQyK3ANLBFonZ/3DGnhJFMJpqjpuA7hCdjHGeN 9PJ4pr4POiGKcRi9JLXpA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Xo62wAmUDv8=:oT1iCjzWA3GUF8uiWlmoG0 lJzLDo0GEjrDax81q4PGtI4h6KxhLFKEoD2s7p/OXA1pWfn6t2cgUt6COiutzXaBrckH/8wAN TPe3F2XH7cbocna/JWKaSpUmLNrUmZlbZF6/9EB6+FcNh+KrVWVun8YSR5yGaD0/HaVq+UIC8 qK3Jrw1i+UN9lQf1X2ZqRhiTwgsRBqTiYRRgwSfeIExVtu0aWAgHCyC85CdJYMNZNXiqQeRuO HCFEKwf5tvmRb2k/g1pYaFxCpzbFI++5R4gyjpSuCYrlQzxpSLA+hE0hp3kiXlvRB06rTzE6z yIWP2Es5paUfcRrAOAZihOMuGPrHVtfWUxOIb2E54SggoJZkwLlNN2+5+X7rpYT2jhzwdr6GM pY/EWNgCZCSfu+i4osqr+bcXIkED9orgGM8FhyzETybuh5PEjKtx9jB72ZVS1wA0LpzwlRmOz fILAchMxpMqO4b0a6fE3g7cdGOMQY8EMLtLhI20y/Bj/rJSJ12/WTK/tjS9QpOWDXJMGulym9 dfIwkSd0AGRl5T87LrLor+K1vYqdwrffnjf0TX4D2fmwLDxxdT/qENsWIUDSKzzn0MHYxy84n aCXlb5vUii7s6x3447DOo2WM+lQs/vtB6JtiDlkwK/epfS1rIn5BGQvk6kUooqc3JAJoWOHzJ KwYz1qbu737MZ4h1gx6xTWj2A9mFtTU4+pv/gNP3DbXJ7mwoU9tv+mpWf4bDn5ALWHQn3XGVS /d2A6Oi5FwiQg4qo3TzT8D/lKfbZDfC+XR4zlFCoiKCi7svYT12pGmb/zraAWp9qcZScaS+Bp 7icMwTDISTnl4qDct26pK9qDIg24sDCkYLUpWCi9D7BEs+jewZ+WLW22cD/j64/n5dYA9jT8i U2Xay88POrh0Wn2Sz2xp/dBIw5EBqYMJXSDruTVEg9+XkFZBcnpQTxxAJ67UDksTq2G8W+nXx 8/izFnuxJPw== Subject: Re: [RFC VOTE] Unbundle ext/interbase From: cmbecker69@gmx.de ("Christoph M. Becker") Hi Kalle, On 02.05.2019 at 15:35, Kalle Sommer Nielsen wrote: > Den tor. 2. maj 2019 kl. 14.56 skrev Christoph M. Becker : >> A problem is that the ext/pdo_firebird tests rely on ext/interbase to >> create a test database[1], which would require everybody who intends to >> run these tests to install PECL/interbase package now. It would be >> great if somebody would rewrite this, so interbase would no longer be a >> dependency of the pdo_firebird tests. >> >> [1] > /testdb.inc> > > Yeah that is one thing that is kind of unfortunate and a bad practice. > However since interbase was disabled for AppVeyor, these tests had no > chance to run in a while. Looking at the actual code in testdb.inc, it > seems like it creates the database for testing purposes, I would > suppose this is due to PDO_Firebird perhaps requiring a database to > continue its connection flow in PDO itself. Indeed, it seems that pdo_firebird requires to connect to an existing database, contrary to e.g. pdo_mysql which supports DSN like `mysql:host=3Dlocalhost`, to my knowledge. But even if pdo_firebird has been connected to an existing database, it appears that it's not possible to create a new database via PDO (I got something like "prepare does not support CREATE DATABASE", even with emulated prepares turned on). > I'm not sure how we can go about this, maybe a .sql file for testers > who run the test suite for schemas and then see if we can integrate > some auto importer in our CI build scripts for this special case? (In > the case we cannot go around PDO). Either way the test files requires > a manual touch to configure credentials to run. > > I'm personally fine with the simple solution, thoughts? ACK. Given that these test did not run on our CI (pdo_firebird is not even built on Travis) anyway, I think a simple solution which allows someone who wants to run the tests after some manual setup is sufficient as a first step. We always could improve on that later. > (ps. Thanks for the fix for the AppVeyor part I missed) No problemo! :) =2D- Christoph M. Becker