Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:105562 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 34483 invoked from network); 2 May 2019 17:01:56 -0000 Received: from unknown (HELO quail.birch.relay.mailchannels.net) (23.83.209.151) by pb1.pair.com with SMTP; 2 May 2019 17:01:56 -0000 X-Sender-Id: s0seqk11zu|x-authuser|lester@lsces.uk Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A00CC3E5783 for ; Thu, 2 May 2019 14:04:34 +0000 (UTC) Received: from draco.thewebhostserver.com (unknown [100.96.28.64]) (Authenticated sender: s0seqk11zu) by relay.mailchannels.net (Postfix) with ESMTPA id B25243E5CB5 for ; Thu, 2 May 2019 14:04:33 +0000 (UTC) X-Sender-Id: s0seqk11zu|x-authuser|lester@lsces.uk Received: from draco.thewebhostserver.com (draco.thewebhostserver.com [185.38.44.226]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Thu, 02 May 2019 14:04:34 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: s0seqk11zu|x-authuser|lester@lsces.uk X-MailChannels-Auth-Id: s0seqk11zu X-Chemical-Madly: 1eeee00b739d012d_1556805874217_2540739112 X-MC-Loop-Signature: 1556805874216:2695411535 X-MC-Ingress-Time: 1556805874215 Received: from static-87-75-107-50.vodafonexdsl.co.uk ([87.75.107.50]:54310 helo=[10.0.0.7]) by draco.thewebhostserver.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1hMCK6-003bWt-TH for internals@lists.php.net; Thu, 02 May 2019 15:04:30 +0100 To: internals@lists.php.net References: <6cc22608-d4b2-e7f4-d534-f4b5f02bc3d2@gmx.de> Message-ID: Date: Thu, 2 May 2019 15:04:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-thewebhostserver-MailScanner-Information: Please contact the ISP for more information X-thewebhostserver-MailScanner-ID: 1hMCK6-003bWt-TH X-thewebhostserver-MailScanner: Found to be clean X-thewebhostserver-MailScanner-SpamCheck: X-thewebhostserver-MailScanner-From: lester@lsces.co.uk X-Spam-Status: No X-AuthUser: lester@lsces.uk Subject: Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase From: lester@lsces.co.uk (Lester) On 02/05/2019 14:35, Kalle Sommer Nielsen wrote: > Hi Christoph > > Den tor. 2. maj 2019 kl. 14.56 skrev Christoph M. Becker : >> A problem is that the ext/pdo_firebird tests rely on ext/interbase to >> create a test database[1], which would require everybody who intends to >> run these tests to install PECL/interbase package now. It would be >> great if somebody would rewrite this, so interbase would no longer be a >> dependency of the pdo_firebird tests. >> >> [1] > /testdb.inc> > > Yeah that is one thing that is kind of unfortunate and a bad practice. > However since interbase was disabled for AppVeyor, these tests had no > chance to run in a while. Looking at the actual code in testdb.inc, it > seems like it creates the database for testing purposes, I would > suppose this is due to PDO_Firebird perhaps requiring a database to > continue its connection flow in PDO itself. > > I'm not sure how we can go about this, maybe a .sql file for testers > who run the test suite for schemas and then see if we can integrate > some auto importer in our CI build scripts for this special case? (In > the case we cannot go around PDO). Either way the test files requires > a manual touch to configure credentials to run. > > I'm personally fine with the simple solution, thoughts? Firebird requires the database to exist before PDO can make a connection and there are a number of ways to handle it, but the simple solution is to use the example database that comes with Firebird. What does complicate things though is that distributions often bundle it separately, and will 'improve security' by not using the default user login. Hence the credentials problem becomes installation dependent. A default install using the official Firebird distributions should work with the test suite using the sample database rather than the temporary one. -- Lester Caine - G8HFL ----------------------------- Contact - https://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - https://lsces.co.uk EnquirySolve - https://enquirysolve.com/ Model Engineers Digital Workshop - https://medw.co.uk Rainbow Digital Media - https://rainbowdigitalmedia.co.uk