Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:105563
To: Lester <lester@lsces.co.uk>, internals@lists.php.net
References: <CAJW__o0KnY=gcLD+vyX1M3HeirUm+UHYh05+nqkpRBefriq3Hg@mail.gmail.com>
 <CAJW__o26mt-REVVgL1OR-cWA7LSfxee3H2Yi2W6qaU1SjP=ujA@mail.gmail.com>
 <6cc22608-d4b2-e7f4-d534-f4b5f02bc3d2@gmx.de>
 <CAJW__o3CoRWWMAtsEWGSHYrcXFnvc9NFo3Ra49+MBwBCbuafjQ@mail.gmail.com>
 <e194f0f9-46f7-e0db-4f0d-4cc25bd0d16f@lsces.co.uk>
Message-ID: <6490a1af-f3bf-b517-f130-098537ceaabf@gmx.de>
Date: Thu, 2 May 2019 16:24:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <e194f0f9-46f7-e0db-4f0d-4cc25bd0d16f@lsces.co.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 02.05.2019 at 16:04, Lester wrote:

> On 02/05/2019 14:35, Kalle Sommer Nielsen wrote:
>
>> Yeah that is one thing that is kind of unfortunate and a bad practice.
>> However since interbase was disabled for AppVeyor, these tests had no
>> chance to run in a while. Looking at the actual code in testdb.inc, it
>> seems like it creates the database for testing purposes, I would
>> suppose this is due to PDO_Firebird perhaps requiring a database to
>> continue its connection flow in PDO itself.
>>
>> I'm not sure how we can go about this, maybe a .sql file for testers
>> who run the test suite for schemas and then see if we can integrate
>> some auto importer in our CI build scripts for this special case? (In
>> the case we cannot go around PDO). Either way the test files requires
>> a manual touch to configure credentials to run.
>>
>> I'm personally fine with the simple solution, thoughts?
>
> Firebird requires the database to exist before PDO can make a connection
> and there are a number of ways to handle it, but the simple solution is
> to use the example database that comes with Firebird. What does
> complicate things though is that distributions often bundle it
> separately, and will 'improve security' by not using the default user
> login. Hence the credentials problem becomes installation dependent. A
> default install using the official Firebird distributions should work
> with the test suite using the sample database rather than the temporary
> one.

A patch would be welcome!

=2D-
Christoph M. Becker