Magic quotes removal previous patch

14 years ago by Pierre Joye — view source — reply

unread

hi,

Please find as attachment the previous patch to remove the magic quotes.

The log I was using back then was (5 years ago already, mq resists :):

Log:

remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
(calling ini_set('magic_....') returns 0|false
get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
return false
set_magic_quotes_runtime raises an E_CORE_ERROR

Cheers,

Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Pierrick Charron — view source — reply

unread

Hi,

I have a more recent one on my laptop. I'll update it tonight or tomorrow to
make sure it work on 5.4 and send it in this thread.

Pierrick

hi,

Please find as attachment the previous patch to remove the magic quotes.

The log I was using back then was (5 years ago already, mq resists :):

Log:

remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
(calling ini_set('magic_....') returns 0|false

get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
return false

set_magic_quotes_runtime raises an E_CORE_ERROR

Cheers,

Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Pierrick Charron — view source — reply

unread

I tried to send the patch as a .txt file but it seems my mail was not
send to internals since i don't see it on news.php.net.

Anyway you'll find patch (code + tests) here :
- http://www.adoy.net/php/remove-magic-quotes.txt
- http://www.adoy.net/php/remove-magic-quotes-tests.txt

Pierrick

hi,

Please find as attachment the previous patch to remove the magic quotes.

The log I was using back then was (5 years ago already, mq resists :):

Log:
- remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
(calling ini_set('magic_....') returns 0|false
- get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
return false
- set_magic_quotes_runtime raises an E_CORE_ERROR

Cheers,

Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Pierre Joye — view source — reply

unread

hi Pierrick!

Thanks for the updated patch :)

Now the only question remaining is which level warning we should use
for the setter. I'm happy with E_CORE. Objections?

I tried to send the patch as a .txt file but it seems my mail was not
send to internals since i don't see it on news.php.net.

Anyway you'll find patch (code + tests) here :
- http://www.adoy.net/php/remove-magic-quotes.txt
- http://www.adoy.net/php/remove-magic-quotes-tests.txt

Pierrick

hi,

Please find as attachment the previous patch to remove the magic quotes.

The log I was using back then was (5 years ago already, mq resists :):

Log:
- remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
(calling ini_set('magic_....') returns 0|false
- get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
return false
- set_magic_quotes_runtime raises an E_CORE_ERROR

Cheers,

Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--

--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Richard Quadling — view source — reply

unread

hi Pierrick!

Thanks for the updated patch :)

Now the only question remaining is which level warning we should use
for the setter. I'm happy with E_CORE. Objections?

Baited breath .... I've got the champagne on ice ... so long mq!

--
Richard Quadling
Twitter : EE : Zend : PHPDoc
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea

14 years ago by Pierrick Charron — view source — reply

unread

I'm also ok with E_CORE.

Pierrick

hi Pierrick!

Thanks for the updated patch :)

Now the only question remaining is which level warning we should use
for the setter. I'm happy with E_CORE. Objections?

I tried to send the patch as a .txt file but it seems my mail was not
send to internals since i don't see it on news.php.net.

Anyway you'll find patch (code + tests) here :
- http://www.adoy.net/php/remove-magic-quotes.txt
- http://www.adoy.net/php/remove-magic-quotes-tests.txt

Pierrick

hi,

Please find as attachment the previous patch to remove the magic quotes.

The log I was using back then was (5 years ago already, mq resists :):

Log:
- remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
(calling ini_set('magic_....') returns 0|false
- get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
return false
- set_magic_quotes_runtime raises an E_CORE_ERROR

Cheers,

Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--

--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Gwynne Raskind — view source — reply

unread

+1 to E_CORE.

-- Gwynne

I'm also ok with E_CORE.

Pierrick

hi Pierrick!

Thanks for the updated patch :)

Now the only question remaining is which level warning we should use
for the setter. I'm happy with E_CORE. Objections?

I tried to send the patch as a .txt file but it seems my mail was not
send to internals since i don't see it on news.php.net.

Anyway you'll find patch (code + tests) here :
- http://www.adoy.net/php/remove-magic-quotes.txt
- http://www.adoy.net/php/remove-magic-quotes-tests.txt

Pierrick

hi,

Please find as attachment the previous patch to remove the magic quotes.

The log I was using back then was (5 years ago already, mq resists :):

Log:
- remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
(calling ini_set('magic_....') returns 0|false
- get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
return false
- set_magic_quotes_runtime raises an E_CORE_ERROR

Cheers,

Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--

--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Paul Dragoonis — view source — reply

unread

On Thu, Jul 21, 2011 at 11:31 AM, Gwynne Raskind
gwynne@darkrainfall.org wrote:

+1 to E_CORE.

No objections against it, so +1 E_CORE

-- Gwynne

I'm also ok with E_CORE.

Pierrick

hi Pierrick!

Thanks for the updated patch :)

Now the only question remaining is which level warning we should use
for the setter. I'm happy with E_CORE. Objections?

I tried to send the patch as a .txt file but it seems my mail was not
send to internals since i don't see it on news.php.net.

Anyway you'll find patch (code + tests) here :
- http://www.adoy.net/php/remove-magic-quotes.txt
- http://www.adoy.net/php/remove-magic-quotes-tests.txt

Pierrick

hi,

Please find as attachment the previous patch to remove the magic quotes.

The log I was using back then was (5 years ago already, mq resists :):

Log:
- remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
(calling ini_set('magic_....') returns 0|false
- get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
return false
- set_magic_quotes_runtime raises an E_CORE_ERROR

Cheers,

Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--

--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Keloran — view source — reply

unread

+1 E_CORE

On Thu, Jul 21, 2011 at 11:46 AM, Paul Dragoonis dragoonis@gmail.comwrote:

On Thu, Jul 21, 2011 at 11:31 AM, Gwynne Raskind
gwynne@darkrainfall.org wrote:

+1 to E_CORE.

No objections against it, so +1 E_CORE

-- Gwynne

On Thu, Jul 21, 2011 at 06:28, Pierrick Charron pierrick@webstart.fr
wrote:

I'm also ok with E_CORE.

Pierrick

hi Pierrick!

Thanks for the updated patch :)

Now the only question remaining is which level warning we should use
for the setter. I'm happy with E_CORE. Objections?

On Thu, Jul 21, 2011 at 2:18 AM, Pierrick Charron <
pierrick@webstart.fr> wrote:

I tried to send the patch as a .txt file but it seems my mail was not
send to internals since i don't see it on news.php.net.

Anyway you'll find patch (code + tests) here :

http://www.adoy.net/php/remove-magic-quotes.txt

http://www.adoy.net/php/remove-magic-quotes-tests.txt

Pierrick

hi,

Please find as attachment the previous patch to remove the magic
quotes.

The log I was using back then was (5 years ago already, mq resists
:):

Log:

remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
(calling ini_set('magic_....') returns 0|false

get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
return false

set_magic_quotes_runtime raises an E_CORE_ERROR

Cheers,

Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--

--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Adam Harvey — view source — reply

unread

Now the only question remaining is which level warning we should use
for the setter. I'm happy with E_CORE. Objections?

None here. +1 for E_CORE_ERROR — it's exactly what it's for.

Adam

14 years ago by Pierre Joye — view source — reply

unread

patch applied to trunk and 5.4, had to resist not to apply it to 5.3 :D

Now the only question remaining is which level warning we should use
for the setter. I'm happy with E_CORE. Objections?

None here. +1 for E_CORE_ERROR — it's exactly what it's for.

Adam

--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

14 years ago by Richard Quadling — view source — reply

unread

patch applied to trunk and 5.4, had to resist not to apply it to 5.3 :D

As the great collective once said, Resistance is futile.

Surrender to your inner-borg.

--
Richard Quadling
Twitter : EE : Zend : PHPDoc
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea