Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54121
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAKxcST-07UGtjktpTC73=2UPSVp8s91k5ZGBh8jvuCe3Qesn1g@mail.gmail.com>
References: <CAEZPtU7wQMiUc_RRXLNWGVgvABcC4KfKH4UhGLCtHa7XjxthvA@mail.gmail.com>
 <CAOfKkdRc8kgk10fgb+yn6Sdn+6ZOEr5U0-Zgry4TDucm99ZaHA@mail.gmail.com>
 <CAEZPtU5x5Exb=Fcr7DmU8iczqAxYu_i3m2=3xz8a+v7X16QS6A@mail.gmail.com>
 <CAOfKkdQXCLkjhK=2yntcNOsy2R7TUe_PsWfibCD3CSAw8XpK7g@mail.gmail.com>
 <CAMWw8k8qGUbTDGtFHxsiE13QoO23XGT178KjQWYgP__sHQBjaA@mail.gmail.com> <CAKxcST-07UGtjktpTC73=2UPSVp8s91k5ZGBh8jvuCe3Qesn1g@mail.gmail.com>
Date: Thu, 21 Jul 2011 12:51:27 +0100
Message-ID: <CAF=va1UT0R5gvAq-YRf-QO2w4EZUBr5gG+hFan+LqSDr2aA_wA@mail.gmail.com>
To: Paul Dragoonis <dragoonis@gmail.com>
Cc: Gwynne Raskind <gwynne@darkrainfall.org>, Pierrick Charron <pierrick@webstart.fr>, 
	Pierre Joye <pierre.php@gmail.com>, PHP internals <internals@lists.php.net>, 
	David Soria Parra <dsp@php.net>, Stanislav Malyshev <stas@php.net>
Content-Type: multipart/alternative; boundary=485b3970cb543dd17704a892f96b
Subject: Re: [PHP-DEV] Magic quotes removal previous patch
From: ava3ar@gmail.com (Keloran)

--485b3970cb543dd17704a892f96b
Content-Type: text/plain; charset=ISO-8859-1

+1 E_CORE

On Thu, Jul 21, 2011 at 11:46 AM, Paul Dragoonis <dragoonis@gmail.com>wrote:

> On Thu, Jul 21, 2011 at 11:31 AM, Gwynne Raskind
> <gwynne@darkrainfall.org> wrote:
> > +1 to E_CORE.
>
> No objections against it, so +1 E_CORE
>
> >
> > -- Gwynne
> >
> >
> >
> > On Thu, Jul 21, 2011 at 06:28, Pierrick Charron <pierrick@webstart.fr>
> wrote:
> >> I'm also ok with E_CORE.
> >>
> >> Pierrick
> >>
> >> On 21 July 2011 05:19, Pierre Joye <pierre.php@gmail.com> wrote:
> >>> hi Pierrick!
> >>>
> >>> Thanks for the updated patch :)
> >>>
> >>> Now the only question remaining is which level warning we should use
> >>> for the setter. I'm happy with E_CORE. Objections?
> >>>
> >>> On Thu, Jul 21, 2011 at 2:18 AM, Pierrick Charron <
> pierrick@webstart.fr> wrote:
> >>>> I tried to send the patch as a .txt file but it seems my mail was not
> >>>> send to internals since i don't see it on news.php.net.
> >>>>
> >>>> Anyway you'll find patch (code + tests) here :
> >>>> - http://www.adoy.net/php/remove-magic-quotes.txt
> >>>> - http://www.adoy.net/php/remove-magic-quotes-tests.txt
> >>>>
> >>>> Pierrick
> >>>>
> >>>> On 20 July 2011 15:44, Pierre Joye <pierre.php@gmail.com> wrote:
> >>>>>
> >>>>> hi,
> >>>>>
> >>>>> Please find as attachment the previous patch to remove the magic
> quotes.
> >>>>>
> >>>>> The log I was using back then was (5 years ago already, mq resists
> :):
> >>>>>
> >>>>>  Log:
> >>>>>  - remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase
> >>>>>  (calling ini_set('magic_....') returns 0|false
> >>>>>  - get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always
> >>>>> return false
> >>>>>  - set_magic_quotes_runtime raises an E_CORE_ERROR
> >>>>>
> >>>>> Cheers,
> >>>>> --
> >>>>> Pierre
> >>>>>
> >>>>> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
> >>>>>
> >>>>> --
> >>>>> PHP Internals - PHP Runtime Development Mailing List
> >>>>> To unsubscribe, visit: http://www.php.net/unsub.php
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Pierre
> >>>
> >>> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
> >>>
> >>
> >> --
> >> PHP Internals - PHP Runtime Development Mailing List
> >> To unsubscribe, visit: http://www.php.net/unsub.php
> >>
> >>
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--485b3970cb543dd17704a892f96b--