Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54120 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10983 invoked from network); 21 Jul 2011 10:46:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jul 2011 10:46:34 -0000 Authentication-Results: pb1.pair.com header.from=dragoonis@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dragoonis@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.170 as permitted sender) X-PHP-List-Original-Sender: dragoonis@gmail.com X-Host-Fingerprint: 209.85.210.170 mail-iy0-f170.google.com Received: from [209.85.210.170] ([209.85.210.170:41114] helo=mail-iy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3F/11-03682-983082E4 for ; Thu, 21 Jul 2011 06:46:34 -0400 Received: by iym1 with SMTP id 1so842769iym.29 for ; Thu, 21 Jul 2011 03:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=qKTn9zKdKoM4kQ83xZQlIL9r+vVs/U5353g/PTrl0/g=; b=FXtySQ6RpR4bZqXCoA9EUUbgcfBPgy1TCy91r/p6eOAS5WgsYg8Mk75ZKgd1asCyTW IFbo47QpiSZQ4uyavaIgr9ERsC5nZ+Bvqmkp4Ftw/7+Vh1e60gPoaEMkEkILeW8JCqbp t//oBhNXJfE0mHG3FjAQ3kmcxMwEnyZgSejag= MIME-Version: 1.0 Received: by 10.231.95.143 with SMTP id d15mr66394ibn.149.1311245189672; Thu, 21 Jul 2011 03:46:29 -0700 (PDT) Received: by 10.42.172.136 with HTTP; Thu, 21 Jul 2011 03:46:29 -0700 (PDT) In-Reply-To: References: Date: Thu, 21 Jul 2011 11:46:29 +0100 Message-ID: To: Gwynne Raskind Cc: Pierrick Charron , Pierre Joye , PHP internals , David Soria Parra , Stanislav Malyshev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Magic quotes removal previous patch From: dragoonis@gmail.com (Paul Dragoonis) On Thu, Jul 21, 2011 at 11:31 AM, Gwynne Raskind wrote: > +1 to E_CORE. No objections against it, so +1 E_CORE > > -- Gwynne > > > > On Thu, Jul 21, 2011 at 06:28, Pierrick Charron wr= ote: >> I'm also ok with E_CORE. >> >> Pierrick >> >> On 21 July 2011 05:19, Pierre Joye wrote: >>> hi Pierrick! >>> >>> Thanks for the updated patch :) >>> >>> Now the only question remaining is which level warning we should use >>> for the setter. I'm happy with E_CORE. Objections? >>> >>> On Thu, Jul 21, 2011 at 2:18 AM, Pierrick Charron wrote: >>>> I tried to send the patch as a .txt file but it seems my mail was not >>>> send to internals since i don't see it on news.php.net. >>>> >>>> Anyway you'll find patch (code + tests) here : >>>> -=A0http://www.adoy.net/php/remove-magic-quotes.txt >>>> -=A0http://www.adoy.net/php/remove-magic-quotes-tests.txt >>>> >>>> Pierrick >>>> >>>> On 20 July 2011 15:44, Pierre Joye wrote: >>>>> >>>>> hi, >>>>> >>>>> Please find as attachment the previous patch to remove the magic quot= es. >>>>> >>>>> The log I was using back then was (5 years ago already, mq resists :)= : >>>>> >>>>> =A0Log: >>>>> =A0- remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_syba= se >>>>> =A0(calling ini_set('magic_....') returns 0|false >>>>> =A0- get_magic_quotes_gpc, get_magic_quotes_runtime are kept but alwa= ys >>>>> return false >>>>> =A0- set_magic_quotes_runtime raises an E_CORE_ERROR >>>>> >>>>> Cheers, >>>>> -- >>>>> Pierre >>>>> >>>>> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >>>>> >>>>> -- >>>>> PHP Internals - PHP Runtime Development Mailing List >>>>> To unsubscribe, visit: http://www.php.net/unsub.php >>>> >>> >>> >>> >>> -- >>> Pierre >>> >>> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >>> >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >