Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54119 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8102 invoked from network); 21 Jul 2011 10:31:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jul 2011 10:31:41 -0000 Authentication-Results: pb1.pair.com header.from=gwynne@darkrainfall.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=gwynne@darkrainfall.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain darkrainfall.org from 209.85.215.173 cause and error) X-PHP-List-Original-Sender: gwynne@darkrainfall.org X-Host-Fingerprint: 209.85.215.173 mail-ey0-f173.google.com Received: from [209.85.215.173] ([209.85.215.173:65124] helo=mail-ey0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FF/90-03682-A00082E4 for ; Thu, 21 Jul 2011 06:31:41 -0400 Received: by eyb7 with SMTP id 7so1415706eyb.4 for ; Thu, 21 Jul 2011 03:31:35 -0700 (PDT) Received: by 10.213.10.71 with SMTP id o7mr155610ebo.103.1311244295362; Thu, 21 Jul 2011 03:31:35 -0700 (PDT) Received: from mail-ew0-f42.google.com (mail-ew0-f42.google.com [209.85.215.42]) by mx.google.com with ESMTPS id y9sm1040781eeh.0.2011.07.21.03.31.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jul 2011 03:31:34 -0700 (PDT) Received: by ewy2 with SMTP id 2so1122221ewy.29 for ; Thu, 21 Jul 2011 03:31:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.27.138 with SMTP id e10mr39621eea.106.1311244294282; Thu, 21 Jul 2011 03:31:34 -0700 (PDT) Received: by 10.14.127.133 with HTTP; Thu, 21 Jul 2011 03:31:33 -0700 (PDT) In-Reply-To: References: Date: Thu, 21 Jul 2011 06:31:33 -0400 Message-ID: To: Pierrick Charron Cc: Pierre Joye , PHP internals , David Soria Parra , Stanislav Malyshev Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Magic quotes removal previous patch From: gwynne@darkrainfall.org (Gwynne Raskind) +1 to E_CORE. -- Gwynne On Thu, Jul 21, 2011 at 06:28, Pierrick Charron wrot= e: > I'm also ok with E_CORE. > > Pierrick > > On 21 July 2011 05:19, Pierre Joye wrote: >> hi Pierrick! >> >> Thanks for the updated patch :) >> >> Now the only question remaining is which level warning we should use >> for the setter. I'm happy with E_CORE. Objections? >> >> On Thu, Jul 21, 2011 at 2:18 AM, Pierrick Charron = wrote: >>> I tried to send the patch as a .txt file but it seems my mail was not >>> send to internals since i don't see it on news.php.net. >>> >>> Anyway you'll find patch (code + tests) here : >>> -=C2=A0http://www.adoy.net/php/remove-magic-quotes.txt >>> -=C2=A0http://www.adoy.net/php/remove-magic-quotes-tests.txt >>> >>> Pierrick >>> >>> On 20 July 2011 15:44, Pierre Joye wrote: >>>> >>>> hi, >>>> >>>> Please find as attachment the previous patch to remove the magic quote= s. >>>> >>>> The log I was using back then was (5 years ago already, mq resists :): >>>> >>>> =C2=A0Log: >>>> =C2=A0- remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sy= base >>>> =C2=A0(calling ini_set('magic_....') returns 0|false >>>> =C2=A0- get_magic_quotes_gpc, get_magic_quotes_runtime are kept but al= ways >>>> return false >>>> =C2=A0- set_magic_quotes_runtime raises an E_CORE_ERROR >>>> >>>> Cheers, >>>> -- >>>> Pierre >>>> >>>> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >>>> >>>> -- >>>> PHP Internals - PHP Runtime Development Mailing List >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >> >> >> >> -- >> Pierre >> >> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >