Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54118 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 6645 invoked from network); 21 Jul 2011 10:29:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jul 2011 10:29:05 -0000 Authentication-Results: pb1.pair.com header.from=pierrick@webstart.fr; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=pierrick@webstart.fr; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain webstart.fr from 74.125.83.170 cause and error) X-PHP-List-Original-Sender: pierrick@webstart.fr X-Host-Fingerprint: 74.125.83.170 mail-pv0-f170.google.com Received: from [74.125.83.170] ([74.125.83.170:48463] helo=mail-pv0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A1/50-03682-E6FF72E4 for ; Thu, 21 Jul 2011 06:29:02 -0400 Received: by pvh11 with SMTP id 11so1014628pvh.29 for ; Thu, 21 Jul 2011 03:28:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.17.73 with SMTP id m9mr124056pbd.180.1311244139531; Thu, 21 Jul 2011 03:28:59 -0700 (PDT) Received: by 10.68.48.98 with HTTP; Thu, 21 Jul 2011 03:28:59 -0700 (PDT) In-Reply-To: References: Date: Thu, 21 Jul 2011 06:28:59 -0400 Message-ID: To: Pierre Joye Cc: PHP internals , David Soria Parra , Stanislav Malyshev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Magic quotes removal previous patch From: pierrick@webstart.fr (Pierrick Charron) I'm also ok with E_CORE. Pierrick On 21 July 2011 05:19, Pierre Joye wrote: > hi Pierrick! > > Thanks for the updated patch :) > > Now the only question remaining is which level warning we should use > for the setter. I'm happy with E_CORE. Objections? > > On Thu, Jul 21, 2011 at 2:18 AM, Pierrick Charron = wrote: >> I tried to send the patch as a .txt file but it seems my mail was not >> send to internals since i don't see it on news.php.net. >> >> Anyway you'll find patch (code + tests) here : >> -=A0http://www.adoy.net/php/remove-magic-quotes.txt >> -=A0http://www.adoy.net/php/remove-magic-quotes-tests.txt >> >> Pierrick >> >> On 20 July 2011 15:44, Pierre Joye wrote: >>> >>> hi, >>> >>> Please find as attachment the previous patch to remove the magic quotes= . >>> >>> The log I was using back then was (5 years ago already, mq resists :): >>> >>> =A0Log: >>> =A0- remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase >>> =A0(calling ini_set('magic_....') returns 0|false >>> =A0- get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always >>> return false >>> =A0- set_magic_quotes_runtime raises an E_CORE_ERROR >>> >>> Cheers, >>> -- >>> Pierre >>> >>> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >>> >>> -- >>> PHP Internals - PHP Runtime Development Mailing List >>> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >