Hi,
can somebody review the following patch:
http://bugs.php.net/bug.php?id=54369
I am willing the bug is fixed in the next PHP release and ready to do a
job if something is wrong with the patch.
Thank you
Regards,
Tomas
2011/4/3 Tomas Brastavičius tbrasta@gmail.com:
Hi,
can somebody review the following patch:
http://bugs.php.net/bug.php?id=54369I am willing the bug is fixed in the next PHP release and ready to do a
job if something is wrong with the patch.Thank you
Regards,
Tomas--
The parsing change you are proposing is invalid per RFC 1738. The
destination (hostname and port) and the url-path are to be divided by
a slash, whereas the query string and the fragment are part of the
latter.
See sections 3.3 and 5 of the RFC[1] for more information. Web
browsers and other user-facing software may accept this, but will
immediately update the displayed URL to a valid variant by inserting
the slash.
Regards,
Peter Beverloo
Le 03/04/2011 13:30, Peter Beverloo a écrit :
The parsing change you are proposing is invalid per RFC 1738.
RFC 1738 has been obsoleted by RFC 3986
2011.04.03 13:58 Tomas Brastavičius rašė:
Hi,
can somebody review the following patch:
http://bugs.php.net/bug.php?id=54369I am willing the bug is fixed in the next PHP release and ready to do a
job if something is wrong with the patch.
Check url encoding documentation first.
http://en.wikipedia.org/wiki/Percent-encoding
Then fix your $url value
Please post relevant comments and information to the bug report
directly. It will make our work and review easier.
Thanks,
On Sun, Apr 3, 2011 at 2:07 PM, Tomas Kuliavas
tokul@users.sourceforge.net wrote:
2011.04.03 13:58 Tomas Brastavičius rašė:
Hi,
can somebody review the following patch:
http://bugs.php.net/bug.php?id=54369I am willing the bug is fixed in the next PHP release and ready to do a
job if something is wrong with the patch.Check url encoding documentation first.
http://en.wikipedia.org/wiki/Percent-encodingThen fix your $url value
--
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org