Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:51806 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14281 invoked from network); 3 Apr 2011 12:18:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Apr 2011 12:18:48 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.161.42 mail-fx0-f42.google.com Received: from [209.85.161.42] ([209.85.161.42:39021] helo=mail-fx0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 54/D5-52504-6A5689D4 for ; Sun, 03 Apr 2011 08:18:47 -0400 Received: by fxm1 with SMTP id 1so3782029fxm.29 for ; Sun, 03 Apr 2011 05:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=k1ORJQU/glDJRyfp9JBM5svCLgr6wKGD99z/KiLvGj8=; b=ke8xO2KfPy2LPvjQaV1dMQyu/zHfvZ9xAe9/t4v2HxNzqEyL6jPh6PipS3R3DNxnOL UD419jIADqywSfiZC1BbWQ3houjbsr1WgKBwUVTMF6kWO4OdXiFIxp3x+HA150R0ckm+ Zg5hkUlMr0bHvj/Aq+0BDyjetmXbYQ0F+e+TQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=n1IhU0edgz56aspwEGflrIfhOVao3neDh1q9Ry+cyJ7jCkWN2lWj/8Q4wdcygVl7Hn 7hMOq98URsjgdowdiyPuRAUnVyOOdEmXuR0Sg2GVKQ59xBML/391SZQC4M3v0n8Bvyjq yvUEf5/EY1w4qd7sF1Ahk/UKdVA+IjwDnCtKc= MIME-Version: 1.0 Received: by 10.223.29.199 with SMTP id r7mr2467852fac.75.1301833123939; Sun, 03 Apr 2011 05:18:43 -0700 (PDT) Received: by 10.223.74.203 with HTTP; Sun, 3 Apr 2011 05:18:43 -0700 (PDT) In-Reply-To: <49032.5626b73e.1301832472.nsm@avilys.eik.lt> References: <1301828287.2187.1.camel@tomas-ubuntu> <49032.5626b73e.1301832472.nsm@avilys.eik.lt> Date: Sun, 3 Apr 2011 14:18:43 +0200 Message-ID: To: Tomas Kuliavas Cc: internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] patch review From: pierre.php@gmail.com (Pierre Joye) Please post relevant comments and information to the bug report directly. It will make our work and review easier. Thanks, On Sun, Apr 3, 2011 at 2:07 PM, Tomas Kuliavas wrote: > 2011.04.03 13:58 Tomas Brastavi=C4=8Dius ra=C5=A1=C4=97: >> Hi, >> >> can somebody review the following patch: >> http://bugs.php.net/bug.php?id=3D54369 >> >> I am willing the bug is fixed in the next PHP release and ready to do a >> job if something is wrong with the patch. > > Check url encoding documentation first. > http://en.wikipedia.org/wiki/Percent-encoding > > Then fix your $url value > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --=20 Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org