Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51805
Return-Path: <tokul@users.sourceforge.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 12410 invoked from network); 3 Apr 2011 12:09:07 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 3 Apr 2011 12:09:07 -0000
Authentication-Results: pb1.pair.com smtp.mail=tokul@users.sourceforge.net; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=tokul@users.sourceforge.net; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain users.sourceforge.net from 77.240.252.9 cause and error)
X-PHP-List-Original-Sender: tokul@users.sourceforge.net
X-Host-Fingerprint: 77.240.252.9 avilys.eik.lt Linux 2.6
Received: from [77.240.252.9] ([77.240.252.9:35218] helo=avilys.eik.lt)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 13/75-52504-163689D4 for <internals@lists.php.net>; Sun, 03 Apr 2011 08:09:06 -0400
Received: from avilys.eik.lt (avilys.local [127.0.0.1])
	by avilys.eik.lt (Postfix) with ESMTP id B2E6A1F51A4
	for <internals@lists.php.net>; Sun,  3 Apr 2011 15:07:52 +0300 (EEST)
Received: from 86.38.183.62
        (NaSMail authenticated user tomas@topolis.lt)
        by avilys.eik.lt with HTTP;
        Sun, 3 Apr 2011 15:07:52 +0300 (EEST)
Message-ID: <49032.5626b73e.1301832472.nsm@avilys.eik.lt>
In-Reply-To: <1301828287.2187.1.camel@tomas-ubuntu>
References: <1301828287.2187.1.camel@tomas-ubuntu>
Date: Sun, 3 Apr 2011 15:07:52 +0300 (EEST)
To: internals@lists.php.net
User-Agent: NaSMail/1.7.1
MIME-Version: 1.0
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
Subject: Re: [PHP-DEV] patch review
From: tokul@users.sourceforge.net ("Tomas Kuliavas")

2011.04.03 13:58 Tomas Brastavičius rašė:
> Hi,
>
> can somebody review the following patch:
> http://bugs.php.net/bug.php?id=54369
>
> I am willing the bug is fixed in the next PHP release and ready to do a
> job if something is wrong with the patch.

Check url encoding documentation first.
http://en.wikipedia.org/wiki/Percent-encoding

Then fix your $url value