Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:51803 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 6788 invoked from network); 3 Apr 2011 11:30:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Apr 2011 11:30:16 -0000 Authentication-Results: pb1.pair.com smtp.mail=peter@lvp-media.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=peter@lvp-media.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lvp-media.com from 209.85.214.170 cause and error) X-PHP-List-Original-Sender: peter@lvp-media.com X-Host-Fingerprint: 209.85.214.170 mail-iw0-f170.google.com Received: from [209.85.214.170] ([209.85.214.170:48632] helo=mail-iw0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0E/74-52504-14A589D4 for ; Sun, 03 Apr 2011 07:30:09 -0400 Received: by iwn3 with SMTP id 3so5700908iwn.29 for ; Sun, 03 Apr 2011 04:30:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.181.20 with SMTP id bw20mr6169559ibb.101.1301830206571; Sun, 03 Apr 2011 04:30:06 -0700 (PDT) Received: by 10.231.159.140 with HTTP; Sun, 3 Apr 2011 04:30:06 -0700 (PDT) In-Reply-To: <1301828287.2187.1.camel@tomas-ubuntu> References: <1301828287.2187.1.camel@tomas-ubuntu> Date: Sun, 3 Apr 2011 13:30:06 +0200 Message-ID: To: =?ISO-8859-13?Q?Tomas_Brastavi=E8ius?= Cc: internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] patch review From: peter@lvp-media.com (Peter Beverloo) 2011/4/3 Tomas Brastavi=C4=8Dius : > Hi, > > can somebody review the following patch: > http://bugs.php.net/bug.php?id=3D54369 > > I am willing the bug is fixed in the next PHP release and ready to do a > job if something is wrong with the patch. > > Thank you > > Regards, > Tomas > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > The parsing change you are proposing is invalid per RFC 1738. The destination (hostname and port) and the url-path are to be divided by a slash, whereas the query string and the fragment are part of the latter. See sections 3.3 and 5 of the RFC[1] for more information. Web browsers and other user-facing software may accept this, but will immediately update the displayed URL to a valid variant by inserting the slash. Regards, Peter Beverloo [1] http://tools.ietf.org/html/rfc1738.html