ereg deprecation?

15 years ago by Michael Maclean — view source — reply

unread

Michael Maclean wrote:

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I was
just remembering that the ereg extension was due to be deprecated in
PHP6 - does this still apply to trunk?

...and by "deprecated" I of course mean "removed". Ahem.

(Thanks Philip!)

--
Cheers,
Michael

15 years ago by Stan Vassilev — view source — reply

unread

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I was
just remembering that the ereg extension was due to be deprecated in
PHP6 - does this still apply to trunk?

Deprecated since 5.3, and was to be removed in 6.0.
In that context, it remains deprecated in all new branches.

Regards,
Stan Vassilev

15 years ago by Philip Olson — view source — reply

unread

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I was just remembering that the ereg extension was due to be deprecated in PHP6 - does this still apply to trunk?

Deprecated since 5.3, and was to be removed in 6.0. In that context, it remains deprecated in all new branches.

In related news, how about adding a --disable-ereg configure option soon. And in more related news, the following manual page is relatively new:

Differences from POSIX regex:

http://php.net/manual/en/reference.pcre.pattern.posix.php

Additional words there would also be helpful.

Regards,
Philip

15 years ago by Felipe Pena — view source — reply

unread

Hi,

2010/4/28 Michael Maclean michael@no-surprises.co.uk

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I was
just remembering that the ereg extension was due to be deprecated in PHP6 -
does this still apply to trunk?

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

--
Regards,
Felipe Pena

15 years ago by Mark Skilbeck — view source — reply

unread

Hi,

2010/4/28 Michael Macleanmichael@no-surprises.co.uk

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I was
just remembering that the ereg extension was due to be deprecated in PHP6 -
does this still apply to trunk?

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

Why does it make no sense? It was clearly deprecated for a reason.

--
Mark Skilbeck
mahcuz.com | gtk.php.net | pecl.php.net/cairo | docs.php.net

15 years ago by johannes@schlueters.de — view source — reply

unread

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

Why does it make no sense? It was clearly deprecated for a reason.

The main reason was that PHP 6 was Unicode and ereg ca't be made working
with Unicode. That reason is gone (for now)
(but there are others, see my other mail)

johannes

15 years ago by johannes@schlueters.de — view source — reply

unread

Hi,

2010/4/28 Michael Maclean michael@no-surprises.co.uk

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I was
just remembering that the ereg extension was due to be deprecated in PHP6 -
does this still apply to trunk?

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

I still won't recommend using ereg - the missing binary-safety causes
quite some broken checks ... is there anything that can be done which
can't be done using pcre? If not: Less code to maintain -> less
trouble :-)

johanns

15 years ago by Lukas Kahwe Smith — view source — reply

unread

Hi,

2010/4/28 Michael Maclean michael@no-surprises.co.uk

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I was
just remembering that the ereg extension was due to be deprecated in PHP6 -
does this still apply to trunk?

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

I still won't recommend using ereg - the missing binary-safety causes
quite some broken checks ... is there anything that can be done which
can't be done using pcre? If not: Less code to maintain -> less
trouble :-)

i would still keep it deprecated simply because people should not write new code with ereg, even if we do not have to remove it because of lack of unicode support.

regards,
Lukas Kahwe Smith
mls@pooteeweet.org

15 years ago by Adam Harvey — view source — reply

unread

2010/6/1 Johannes Schlüter johannes@schlueters.de:

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

I still won't recommend using ereg - the missing binary-safety causes
quite some broken checks ... is there anything that can be done which
can't be done using pcre? If not: Less code to maintain -> less
trouble :-)

I believe PCRE's generally quicker into the bargain anyway.

We've already told people we're killing ereg, and there are good
reasons to do so regardless of Unicode (lack of binary safety being
the main one, with the needless duplication with PCRE being another).
Let's keep it deprecated and kill it when it makes sense to do so
(next major, or if and when Unicode comes back at some future date).

Adam

15 years ago by Felipe Pena — view source — reply

unread

2010/5/31 Johannes Schlüter johannes@schlueters.de

Hi,

2010/4/28 Michael Maclean michael@no-surprises.co.uk

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I
was
just remembering that the ereg extension was due to be deprecated in
PHP6 -
does this still apply to trunk?

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

I still won't recommend using ereg - the missing binary-safety causes
quite some broken checks ... is there anything that can be done which
can't be done using pcre? If not: Less code to maintain -> less
trouble :-)

I also won't recommend using ereg, I just thought the unique reason to
deprecate it was the unicode stuff, hence wouldn't make sense to keep it
deprecated... But as there are others motivations, I prefer leave as is too.

--
Regards,
Felipe Pena

15 years ago by Peter Beverloo — view source — reply

unread

2010/5/31 Felipe Pena felipensp@gmail.com

2010/5/31 Johannes Schlüter johannes@schlueters.de

Hi,

2010/4/28 Michael Maclean michael@no-surprises.co.uk

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I
was
just remembering that the ereg extension was due to be deprecated in
PHP6 -
does this still apply to trunk?

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

I still won't recommend using ereg - the missing binary-safety causes
quite some broken checks ... is there anything that can be done which
can't be done using pcre? If not: Less code to maintain -> less
trouble :-)

I also won't recommend using ereg, I just thought the unique reason to
deprecate it was the unicode stuff, hence wouldn't make sense to keep it
deprecated... But as there are others motivations, I prefer leave as is too.

--
Regards,
Felipe Pena

Undeprecating the ereg extension now will not only cause confusion,
because it has been deprecated for quite a while already, but it might
also become a liability if Unicode or any similar non-compatible
system might ever be included in the future.

PCRE simply is faster under most conditions, more consistent and since
a significant part of PHP Developers will also use Javascript, likely
to be more appropriate for the web. Companies and individuals have
been adjusting their scripts in favor of PCRE[1][2][3], undeprecating
the extension seems senseless at this point.

I do think Philip Olson's proposal of adding a compile-time flag for
disabling ereg altogether is a good idea, as it would be the next step
in moving ereg away from PHP's core.

Regards,
Peter Beverloo

[1] https://drupal.org/node/530940
[2] http://bugs.typo3.org/view.php?id=9994
[3] http://www.mantisbt.org/bugs/view.php?id=10974

15 years ago by Stas Malyshev — view source — reply

unread

Hi!

I also won't recommend using ereg, I just thought the unique reason to
deprecate it was the unicode stuff, hence wouldn't make sense to keep it
deprecated... But as there are others motivations, I prefer leave as is too.

I think we have enough reasons to keep it deprecated as we have much
better alternative (pcre) which we want to recommend to the users.

Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

15 years ago by Pierre Joye — view source — reply

unread

hi,

I don't think we should remove it. The sooner users stop to use ereg,
the better.

Cheers,

Pierre

Hi,

2010/4/28 Michael Maclean michael@no-surprises.co.uk

Hi,
I think I asked this before on IRC, but I've forgotten the answer. I was
just remembering that the ereg extension was due to be deprecated in PHP6 -
does this still apply to trunk?

I think make no sense to keep it deprecated.

Here's a patch for undeprecate ext/ereg in 5_3 and trunk:
http://felipe.ath.cx/diff/undeprecate-ereg.diff

Any objection? If no, I'll commit it in soon.

--
Regards,
Felipe Pena

--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

I think we have enough reasons to keep it deprecated as we have much better alternative (pcre) which we want to recommend to the users.

Cheers,

I think we have enough reasons to keep it deprecated as we have much
better alternative (pcre) which we want to recommend to the users.