Bug 47468: enabling readline/libedit/pcntl/ncurses with --enable-embed

17 years ago by Paul Biggar — view source — reply

unread

Hi folks,

Could I get someone to look at http://bugs.php.net/bug.php?id=47468?.
It includes a patch which is confirmed to fix the problem.

Thanks,
Paul

--
Paul Biggar
paul.biggar@gmail.com

17 years ago by Arnaud Le Blanc — view source — reply

unread

Hi,

Hi folks,

Could I get someone to look at http://bugs.php.net/bug.php?id=47468?.
It includes a patch which is confirmed to fix the problem.

Does the following patch works for you ? (use ./buildconf after
applying, then reconfigure). It does the same thing as yours, but moves
the decision of allowing "cli" extensions to SAPI's config.m4.

Lukas, Johannes, any objection ?

Regards,

Arnaud

17 years ago by Paul Biggar — view source — reply

unread

Hi Arnaud,

Thanks for looking at this.

Does the following patch works for you ? (use ./buildconf after
applying, then reconfigure). It does the same thing as yours, but moves
the decision of allowing "cli" extensions to SAPI's config.m4.

I tested this on CVS 5.3 (with the configure command: ./configure
--with-readline --enable-embed --enable-maintainer-zts
--enable-debug). It applies cleanly, and I checked the readline
symbols were present. I have also forwarded it to two of phc's users
who reported the bug. I expect they'll be back to me within a day or
two, if you prefer to wait for further confirmation.

FWIW, I like the new patch better than my hack. However, I don't
understand the how it works from the comment (that bit of acinclude is
very shoddily documented in general).

Thanks again,
Paul

--
Paul Biggar
paul.biggar@gmail.com

17 years ago by Arnaud Le Blanc — view source — reply

unread

Hi Arnaud,

Thanks for looking at this.

Does the following patch works for you ? (use ./buildconf after
applying, then reconfigure). It does the same thing as yours, but moves
the decision of allowing "cli" extensions to SAPI's config.m4.

I tested this on CVS 5.3 (with the configure command: ./configure
--with-readline --enable-embed --enable-maintainer-zts
--enable-debug). It applies cleanly, and I checked the readline
symbols were present. I have also forwarded it to two of phc's users
who reported the bug. I expect they'll be back to me within a day or
two, if you prefer to wait for further confirmation.

FWIW, I like the new patch better than my hack. However, I don't
understand the how it works from the comment (that bit of acinclude is
very shoddily documented in general).

The build system allows to build two SAPIs at a time: the CLI and a SAPI
of choice. Some extensions are irrelevant for webserver SAPIs, so they
mark themselves as CLI-only extensions. This allows one to enable these
extensions in the CLI without enabling them in the server SAPI. This
patch allows a SAPI to mark itself as allowing those extensions.

Regards,

Arnaud

17 years ago by Jani Taskinen — view source — reply

unread

Arnaud Le Blanc kirjoitti:

Hi Arnaud,

Thanks for looking at this.

Does the following patch works for you ? (use ./buildconf after
applying, then reconfigure). It does the same thing as yours, but moves
the decision of allowing "cli" extensions to SAPI's config.m4.
I tested this on CVS 5.3 (with the configure command: ./configure
--with-readline --enable-embed --enable-maintainer-zts
--enable-debug). It applies cleanly, and I checked the readline
symbols were present. I have also forwarded it to two of phc's users
who reported the bug. I expect they'll be back to me within a day or
two, if you prefer to wait for further confirmation.

FWIW, I like the new patch better than my hack. However, I don't
understand the how it works from the comment (that bit of acinclude is
very shoddily documented in general).

The build system allows to build two SAPIs at a time: the CLI and a SAPI
of choice. Some extensions are irrelevant for webserver SAPIs, so they
mark themselves as CLI-only extensions. This allows one to enable these
extensions in the CLI without enabling them in the server SAPI. This
patch allows a SAPI to mark itself as allowing those extensions.

I really need to sleep before I read this again, but with a quick look at the
patch I couldn't figure what you're fixing and where. :)

PLEASE don't commit this before I can check it out.

--Jani

17 years ago by Arnaud Le Blanc — view source — reply

unread

Arnaud Le Blanc kirjoitti:

Hi Arnaud,

Thanks for looking at this.

Does the following patch works for you ? (use ./buildconf after
applying, then reconfigure). It does the same thing as yours, but moves
the decision of allowing "cli" extensions to SAPI's config.m4.
I tested this on CVS 5.3 (with the configure command: ./configure
--with-readline --enable-embed --enable-maintainer-zts
--enable-debug). It applies cleanly, and I checked the readline
symbols were present. I have also forwarded it to two of phc's users
who reported the bug. I expect they'll be back to me within a day or
two, if you prefer to wait for further confirmation.

FWIW, I like the new patch better than my hack. However, I don't
understand the how it works from the comment (that bit of acinclude is
very shoddily documented in general).

The build system allows to build two SAPIs at a time: the CLI and a SAPI
of choice. Some extensions are irrelevant for webserver SAPIs, so they
mark themselves as CLI-only extensions. This allows one to enable these
extensions in the CLI without enabling them in the server SAPI. This
patch allows a SAPI to mark itself as allowing those extensions.

I really need to sleep before I read this again, but with a quick look at the
patch I couldn't figure what you're fixing and where. :)

Reproduce code:
"./configure --with-readline --enable-embed && make"

Expected result:
libphp5.so with readline extension builtin

Actual result:
libphp5.so without readline extension

Regards,

Arnaud

17 years ago by Jani Taskinen — view source — reply

unread

Arnaud Le Blanc kirjoitti:

Arnaud Le Blanc kirjoitti:

Hi Arnaud,

Thanks for looking at this.

Does the following patch works for you ? (use ./buildconf after
applying, then reconfigure). It does the same thing as yours, but moves
the decision of allowing "cli" extensions to SAPI's config.m4.
I tested this on CVS 5.3 (with the configure command: ./configure
--with-readline --enable-embed --enable-maintainer-zts
--enable-debug). It applies cleanly, and I checked the readline
symbols were present. I have also forwarded it to two of phc's users
who reported the bug. I expect they'll be back to me within a day or
two, if you prefer to wait for further confirmation.

FWIW, I like the new patch better than my hack. However, I don't
understand the how it works from the comment (that bit of acinclude is
very shoddily documented in general).
The build system allows to build two SAPIs at a time: the CLI and a SAPI
of choice. Some extensions are irrelevant for webserver SAPIs, so they
mark themselves as CLI-only extensions. This allows one to enable these
extensions in the CLI without enabling them in the server SAPI. This
patch allows a SAPI to mark itself as allowing those extensions.
I really need to sleep before I read this again, but with a quick look at the
patch I couldn't figure what you're fixing and where. :)

Reproduce code:
"./configure --with-readline --enable-embed && make"

Expected result:
libphp5.so with readline extension builtin

Actual result:
libphp5.so without readline extension

I fixed this the simplest way. Please, KISS with this is better than adding
yet-another-parameter to forget.

--Jani

Bug 47468: enabling readline/libedit/pcntl/ncurses with --enable-embed View as Markdown