Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43877
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.179 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=YDNu3jj5sdqSRgfRQuq5KwJSX/4JYFFP222yBCauc4dUj/0V/SrTm2/CgjRJqGPk5V
         9hfg4iBnKu2I2lpHbKDbWzU8aGJu3k88YyH9GpfGuJwcZw1rtsUqkhfVJjqmhpM9IbS9
         EAd/7XLRFFSOMheyEmcmwGVydA35tdSX+fkcA=
Sender: Arnaud LB <arnaud.lb@gmail.com>
To: jani.taskinen@iki.fi
Cc: Paul Biggar <paul.biggar@gmail.com>, PHP Internals <internals@lists.php.net>,  Johannes =?ISO-8859-1?Q?Schl=FCter?= <johannes@php.net>, Lukas Kahwe Smith <mls@pooteeweet.org>
In-Reply-To: <4A04D241.10201@sci.fi>
References: <af54caaf0905061242p2f97b1f7s43494148bc7abe3e@mail.gmail.com>
	 <1241788319.7724.31.camel@localhost>
	 <af54caaf0905080812s6f1908d6tf3bc65fd9ba395f6@mail.gmail.com>
	 <1241798403.7724.51.camel@localhost>  <4A04D241.10201@sci.fi>
Content-Type: text/plain
Date: Sat, 09 May 2009 15:30:42 +0200
Message-ID: <1241875842.8056.29.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Bug 47468: enabling readline/libedit/pcntl/ncurses
 with  --enable-embed
From: lbarnaud@php.net (Arnaud Le Blanc)

On Sat, 2009-05-09 at 03:45 +0300, Jani Taskinen wrote:
> Arnaud Le Blanc kirjoitti:
> > On Fri, 2009-05-08 at 16:12 +0100, Paul Biggar wrote:
> >> Hi Arnaud,
> >>
> >> Thanks for looking at this.
> >>
> >> On Fri, May 8, 2009 at 2:11 PM, Arnaud Le Blanc <lbarnaud@php.net> wrote:
> >>> Does the following patch works for you ? (use ./buildconf after
> >>> applying, then reconfigure). It does the same thing as yours, but moves
> >>> the decision of allowing "cli" extensions to SAPI's config.m4.
> >> I tested this on CVS 5.3 (with the configure command: ./configure
> >> --with-readline --enable-embed --enable-maintainer-zts
> >> --enable-debug). It applies cleanly, and I checked the readline
> >> symbols were present. I have also forwarded it to two of phc's users
> >> who reported the bug. I expect they'll be back to me within a day or
> >> two, if you prefer to wait for further confirmation.
> >>
> >> FWIW, I like the new patch better than my hack. However, I don't
> >> understand the how it works from the comment (that bit of acinclude is
> >> very shoddily documented in general).
> > 
> > The build system allows to build two SAPIs at a time: the CLI and a SAPI
> > of choice. Some extensions are irrelevant for webserver SAPIs, so they
> > mark themselves as CLI-only extensions. This allows one to enable these
> > extensions in the CLI without enabling them in the server SAPI. This
> > patch allows a SAPI to mark itself as allowing those extensions.
> 
> I really need to sleep before I read this again, but with a quick look at the 
> patch I couldn't figure what you're fixing and where. :)

Reproduce code:
"./configure --with-readline --enable-embed && make"

Expected result:
libphp5.so with readline extension builtin

Actual result:
libphp5.so without readline extension

Regards,

Arnaud