Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:43878
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain sci.fi from 204.13.248.71 cause and error)
Message-ID: <4A05E78B.6010005@sci.fi>
Date: Sat, 09 May 2009 23:28:59 +0300
Reply-To: jani.taskinen@iki.fi
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: Arnaud Le Blanc <lbarnaud@php.net>
CC: jani.taskinen@iki.fi, Paul Biggar <paul.biggar@gmail.com>, 
 PHP Internals <internals@lists.php.net>,
 =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@php.net>, 
 Lukas Kahwe Smith <mls@pooteeweet.org>
References: <af54caaf0905061242p2f97b1f7s43494148bc7abe3e@mail.gmail.com>	 <1241788319.7724.31.camel@localhost>	 <af54caaf0905080812s6f1908d6tf3bc65fd9ba395f6@mail.gmail.com>	 <1241798403.7724.51.camel@localhost>  <4A04D241.10201@sci.fi> <1241875842.8056.29.camel@localhost>
In-Reply-To: <1241875842.8056.29.camel@localhost>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Bug 47468: enabling readline/libedit/pcntl/ncurses
 with  --enable-embed
From: jani.taskinen@sci.fi (Jani Taskinen)

Arnaud Le Blanc kirjoitti:
> On Sat, 2009-05-09 at 03:45 +0300, Jani Taskinen wrote:
>> Arnaud Le Blanc kirjoitti:
>>> On Fri, 2009-05-08 at 16:12 +0100, Paul Biggar wrote:
>>>> Hi Arnaud,
>>>>
>>>> Thanks for looking at this.
>>>>
>>>> On Fri, May 8, 2009 at 2:11 PM, Arnaud Le Blanc <lbarnaud@php.net> wrote:
>>>>> Does the following patch works for you ? (use ./buildconf after
>>>>> applying, then reconfigure). It does the same thing as yours, but moves
>>>>> the decision of allowing "cli" extensions to SAPI's config.m4.
>>>> I tested this on CVS 5.3 (with the configure command: ./configure
>>>> --with-readline --enable-embed --enable-maintainer-zts
>>>> --enable-debug). It applies cleanly, and I checked the readline
>>>> symbols were present. I have also forwarded it to two of phc's users
>>>> who reported the bug. I expect they'll be back to me within a day or
>>>> two, if you prefer to wait for further confirmation.
>>>>
>>>> FWIW, I like the new patch better than my hack. However, I don't
>>>> understand the how it works from the comment (that bit of acinclude is
>>>> very shoddily documented in general).
>>> The build system allows to build two SAPIs at a time: the CLI and a SAPI
>>> of choice. Some extensions are irrelevant for webserver SAPIs, so they
>>> mark themselves as CLI-only extensions. This allows one to enable these
>>> extensions in the CLI without enabling them in the server SAPI. This
>>> patch allows a SAPI to mark itself as allowing those extensions.
>> I really need to sleep before I read this again, but with a quick look at the 
>> patch I couldn't figure what you're fixing and where. :)
> 
> Reproduce code:
> "./configure --with-readline --enable-embed && make"
> 
> Expected result:
> libphp5.so with readline extension builtin
> 
> Actual result:
> libphp5.so without readline extension

I fixed this the simplest way. Please, KISS with this is better than adding 
yet-another-parameter to forget.

--Jani