Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43876 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86304 invoked from network); 9 May 2009 00:45:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 May 2009 00:45:59 -0000 Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 204.13.248.71 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 204.13.248.71 mho-01-ewr.mailhop.org Received: from [204.13.248.71] ([204.13.248.71:65184] helo=mho-01-ewr.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D8/C1-08898-542D40A4 for ; Fri, 08 May 2009 20:45:58 -0400 Received: from cs181029147.pp.htv.fi ([82.181.29.147] helo=[127.0.0.1]) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1M2ahN-000Pwo-TL; Sat, 09 May 2009 00:45:54 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 82.181.29.147 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+gb9zTaGal+X+eD8TVgZxAB222U+RuERw= Message-ID: <4A04D241.10201@sci.fi> Date: Sat, 09 May 2009 03:45:53 +0300 Reply-To: jani.taskinen@iki.fi User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Arnaud Le Blanc CC: Paul Biggar , PHP Internals , =?ISO-8859-1?Q?Johannes_Schl=FCter?= , Lukas Kahwe Smith References: <1241788319.7724.31.camel@localhost> <1241798403.7724.51.camel@localhost> In-Reply-To: <1241798403.7724.51.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Bug 47468: enabling readline/libedit/pcntl/ncurses with --enable-embed From: jani.taskinen@sci.fi (Jani Taskinen) Arnaud Le Blanc kirjoitti: > On Fri, 2009-05-08 at 16:12 +0100, Paul Biggar wrote: >> Hi Arnaud, >> >> Thanks for looking at this. >> >> On Fri, May 8, 2009 at 2:11 PM, Arnaud Le Blanc wrote: >>> Does the following patch works for you ? (use ./buildconf after >>> applying, then reconfigure). It does the same thing as yours, but moves >>> the decision of allowing "cli" extensions to SAPI's config.m4. >> I tested this on CVS 5.3 (with the configure command: ./configure >> --with-readline --enable-embed --enable-maintainer-zts >> --enable-debug). It applies cleanly, and I checked the readline >> symbols were present. I have also forwarded it to two of phc's users >> who reported the bug. I expect they'll be back to me within a day or >> two, if you prefer to wait for further confirmation. >> >> FWIW, I like the new patch better than my hack. However, I don't >> understand the how it works from the comment (that bit of acinclude is >> very shoddily documented in general). > > The build system allows to build two SAPIs at a time: the CLI and a SAPI > of choice. Some extensions are irrelevant for webserver SAPIs, so they > mark themselves as CLI-only extensions. This allows one to enable these > extensions in the CLI without enabling them in the server SAPI. This > patch allows a SAPI to mark itself as allowing those extensions. I really need to sleep before I read this again, but with a quick look at the patch I couldn't figure what you're fixing and where. :) PLEASE don't commit this before I can check it out. --Jani