Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:43873 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18472 invoked from network); 8 May 2009 15:13:03 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 May 2009 15:13:03 -0000 Authentication-Results: pb1.pair.com header.from=paul.biggar@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=paul.biggar@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.221.195 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: paul.biggar@gmail.com X-Host-Fingerprint: 209.85.221.195 mail-qy0-f195.google.com Received: from [209.85.221.195] ([209.85.221.195:56415] helo=mail-qy0-f195.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A9/73-33784-EFB440A4 for ; Fri, 08 May 2009 11:13:03 -0400 Received: by qyk33 with SMTP id 33so2309644qyk.29 for ; Fri, 08 May 2009 08:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=AGKBHrHGTT4Nnxi/WXb10Vs/kd4mz9dHNWuRk+nL5tc=; b=Cdal3jWOQUBgxGHwsRAZIgDqasF5JSuxcGskY9rn1hkwAmL7fLjltr6tARv9/MfxfF jTT9YP8DXxPtq5x9oOqaF1zveLs2/wRc5L4U7NNjPCLFaqhNrjgnWzkqkofTaMmiwSn4 nZRtd1KEaNfzIOM80wOq++HwwEATIFEXN6wSw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=dwobnY7UGFgf+rwdAFRX5hdw3L8FO51TujxEhKmbpe2KB7i2YzmcJrVGuEP4+UrFFF Tb9/m2AtoiW8YRS2Xa/kTmqaupUh8vBRSRrwOx0pHJJuUVhHgckEuck0kfKvD7Yz8SB3 6bUh3xqJ9thcn6RRVUlv2yXz/eXLtO7DTWYZI= MIME-Version: 1.0 Received: by 10.231.11.141 with SMTP id t13mr1289716ibt.28.1241795579122; Fri, 08 May 2009 08:12:59 -0700 (PDT) In-Reply-To: <1241788319.7724.31.camel@localhost> References: <1241788319.7724.31.camel@localhost> Date: Fri, 8 May 2009 16:12:39 +0100 Message-ID: To: Arnaud Le Blanc Cc: PHP Internals , =?UTF-8?Q?Johannes_Schl=C3=BCter?= , Lukas Kahwe Smith Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Bug 47468: enabling readline/libedit/pcntl/ncurses with --enable-embed From: paul.biggar@gmail.com (Paul Biggar) Hi Arnaud, Thanks for looking at this. On Fri, May 8, 2009 at 2:11 PM, Arnaud Le Blanc wrote: > Does the following patch works for you ? (use ./buildconf after > applying, then reconfigure). It does the same thing as yours, but moves > the decision of allowing "cli" extensions to SAPI's config.m4. I tested this on CVS 5.3 (with the configure command: ./configure --with-readline --enable-embed --enable-maintainer-zts --enable-debug). It applies cleanly, and I checked the readline symbols were present. I have also forwarded it to two of phc's users who reported the bug. I expect they'll be back to me within a day or two, if you prefer to wait for further confirmation. FWIW, I like the new patch better than my hack. However, I don't understand the how it works from the comment (that bit of acinclude is very shoddily documented in general). Thanks again, Paul -- Paul Biggar paul.biggar@gmail.com