zend_get_parameters_ex rework View as Markdown

Hi Lester,

OK I've got a patch for master, but I know that the changes are not
complete!

http://hg.lsces.org.uk/hg/php-src/rev/8ec9101f59b6

I've still got a question about the &string_arg on line 1.9 and if it
should be changed to a string but that change needs working through the
following code.

Also is what I'm doing here php7 only? so should there be wrappers for a
PHP5 build?

I think we need modules for PHP5 and PHP7.
They differ a lot.

I think that all this leaves is all the complaints about 'NULL' and integer

initialization makes integer from pointer without a cast
and
assignment makes integer from pointer without a cast

1.9 + if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
"rr", &blob_arg, &string_arg)) {

I don't read the code and just curious.
The "string_arg" isn't string? Why you specify "r" (resource)? Is it badly
named parameter or some kind of string resource?

It may be easier for you and us, if you could use github.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

in interbase/ibase_blobs.c

 zval *blob_arg, *string_arg;
 ibase_blob *ib_blob;

 RESET_ERRMSG;

 if (ZEND_NUM_ARGS() != 2 || zend_get_parameters_ex(2, &blob_arg,

&string_arg) == FAILURE) {

         WRONG_PARAM_COUNT;
 }

 ZEND_FETCH_RESOURCE(ib_blob, ibase_blob *, blob_arg, -1,

"Interbase blob", le_blob);

I've got that if changes to

  if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,

"rr", &blob_arg, &string_arg)) {

          return;
 }

But I suspect I need to change the *string_arg to a character string so
'rc' and add a string_len field. At least that is what I think I'm
seeing from the samples I have found.

OK I've got a patch for master, but I know that the changes are not
complete!

http://hg.lsces.org.uk/hg/php-src/rev/8ec9101f59b6

In ibase_blob_get you're declaring 'len_arg' as 'unsigned long'. If you're
using the 'l' type in zpp you should use the 'zend_long' type instead -
otherwise it will not work correctly on LLP64 (aka Windows) systems.

I've still got a question about the &string_arg on line 1.9 and if it
should be changed to a string but that change needs working through the
following code.

Yes, this should be changed to a string. E.g. use the 'S' zpp modifier and
declare the variable as 'zend_string *str'. Then modify the places where it
is used from Z_STRVAL_P(...) to str->val and Z_STRLEN_P(...) to str->len.

Also is what I'm doing here php7 only? so should there be wrappers for a
PHP5 build?

Apart form a few special exceptions we keep PHP7-only codebases in php-src.
They don't need to (and shouldn't) contain any compat code.

As another tip: If you want to link to code in the PHP codebase, I
recommend using http://lxr.php.net/xref/PHP_TRUNK/ instead of GitHub -
lxr.php.net is cross-referenced, so you can click through function usages.

Nikita

Lester Caine in php.internals (Wed, 11 Feb 2015 12:43:05 +0000):

OK I've got a patch for master, but I know that the changes are not
complete!

http://hg.lsces.org.uk/hg/php-src/rev/8ec9101f59b6

This one might be a little bit more complete:
https://github.com/Jan-E/php-src/commit/8c920a22ac65da485eaf3d2fd27baf2b0406116e

Could you test that one? I did it as a sort of PHP7 exercise, but I do
not have Interbase running.

Jan