Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82522
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.214 cause and error)
Message-ID: <54DC89AD.9080507@lsces.co.uk>
Date: Thu, 12 Feb 2015 11:08:29 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: "internals@lists.php.net" <internals@lists.php.net>
References: <54DA162D.1070806@lsces.co.uk> <54DB4E59.4030503@lsces.co.uk> <CAGa2bXYzEMGzuBv_MQknSG-4Ygj6JozYNyemRrpsuAf4+Ws+4g@mail.gmail.com>
In-Reply-To: <CAGa2bXYzEMGzuBv_MQknSG-4Ygj6JozYNyemRrpsuAf4+Ws+4g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] zend_get_parameters_ex rework
From: lester@lsces.co.uk (Lester Caine)

On 12/02/15 10:10, Yasuo Ohgaki wrote:
> 
>  1.9 +if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
> "rr", &blob_arg, &string_arg)) {
> 
> I don't read the code and just curious.
> The "string_arg" isn't string? Why you specify "r" (resource)? Is it
> badly named parameter or some kind of string resource?

This is the bit I have asked about a couple of times already ;)
That value is passed to a second function _php_ibase_blob_add which
expects a zval, but I don't think that this is necessary now? It is a
block of data rather than a text string as such and may include unicode
or other binary data. What it does has not changed since 1990's only how
PHP handles it.

> It may be easier for you and us, if you could use github.

My local repo is just a mirror of git.php.net and I can work from that
locally direct off eclipse which includes stuff I will never backup to
github. 'You don't have to use git' was one of the promises when that
was force on us ... I have an account, but forking php-src just to work
on a couple of extensions is pointless.

Back to code ...
https://github.com/php/php-src/blob/master/ext/interbase/ibase_blobs.c
Line 318 passes string_arg to function at 131
( this is so much easier using eclipse to navigate :) )

The other compile problem I have is the complaints about casting
pointers to integer ...

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk