Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:82542
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54DC9FB3.2040801@lsces.co.uk>
References: <54DA162D.1070806@lsces.co.uk>
	<54DB4E59.4030503@lsces.co.uk>
	<CAF+90c-oN5U_znvOGNedsoegAwNvgjgp9imhJHbgcixUESJLeg@mail.gmail.com>
	<54DC9FB3.2040801@lsces.co.uk>
Date: Thu, 12 Feb 2015 17:12:39 +0200
Message-ID: <CAPv8svW-kBFga=ygz3jMfA_vncskmSw43GhD1JJXizNFVrw76A@mail.gmail.com>
To: Lester Caine <lester@lsces.co.uk>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e013d12d6fad02e050ee58c47
Subject: Re: [PHP-DEV] zend_get_parameters_ex rework
From: mapopa@gmail.com (marius adrian popa)

--089e013d12d6fad02e050ee58c47
Content-Type: text/plain; charset=UTF-8

Finish the patch and i will apply , also ZEND_FETCH_RESOURCE2 must be
replaced with
zend_fetch_resource2 like it was done in pgsql case

https://github.com/php/php-src/commit/0d4255de30314dbfa32827e044b35543b1ae5a39


On Thu, Feb 12, 2015 at 2:42 PM, Lester Caine <lester@lsces.co.uk> wrote:

> On 12/02/15 11:35, Nikita Popov wrote:
> >     I've still got a question about the &string_arg on line 1.9 and if it
> >     should be changed to a string but that change needs working through
> the
> >     following code.
> >
> >
> > Yes, this should be changed to a string. E.g. use the 'S' zpp modifier
> > and declare the variable as 'zend_string *str'. Then modify the places
> > where it is used from Z_STRVAL_P(...) to str->val and Z_STRLEN_P(...) to
> > str->len.
>
> OK that makes sense ... and I though I was on a roll, except while I can
> convert one of the uses, another is feed by a zval which I then need to
> convert to a zend_string, but I think I can just change b_val to
> Z_STR*(b_val) but the compiler is saying that Z_STR is not defined?
>
> I've spent half an hour trying to dig around but not managed to find
> what I should be using :(
>
> --
> Lester Caine - G8HFL
> -----------------------------
> Contact - http://lsces.co.uk/wiki/?page=contact
> L.S.Caine Electronic Services - http://lsces.co.uk
> EnquirySolve - http://enquirysolve.com/
> Model Engineers Digital Workshop - http://medw.co.uk
> Rainbow Digital Media - http://rainbowdigitalmedia.co.uk
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--089e013d12d6fad02e050ee58c47--