Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:82529 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71669 invoked from network); 12 Feb 2015 12:42:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Feb 2015 12:42:32 -0000 Authentication-Results: pb1.pair.com smtp.mail=lester@lsces.co.uk; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=lester@lsces.co.uk; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.214 cause and error) X-PHP-List-Original-Sender: lester@lsces.co.uk X-Host-Fingerprint: 217.147.176.214 mail4-2.serversure.net Linux 2.6 Received: from [217.147.176.214] ([217.147.176.214:34542] helo=mail4.serversure.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CA/04-50473-6BF9CD45 for ; Thu, 12 Feb 2015 07:42:31 -0500 Received: (qmail 5592 invoked by uid 89); 12 Feb 2015 12:42:27 -0000 Received: by simscan 1.3.1 ppid: 5586, pid: 5589, t: 0.0668s scanners: attach: 1.3.1 clamav: 0.96/m:52/d:10677 Received: from unknown (HELO ?10.0.0.8?) (lester@rainbowdigitalmedia.org.uk@86.189.147.37) by mail4.serversure.net with ESMTPA; 12 Feb 2015 12:42:27 -0000 Message-ID: <54DC9FB3.2040801@lsces.co.uk> Date: Thu, 12 Feb 2015 12:42:27 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: PHP internals References: <54DA162D.1070806@lsces.co.uk> <54DB4E59.4030503@lsces.co.uk> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] zend_get_parameters_ex rework From: lester@lsces.co.uk (Lester Caine) On 12/02/15 11:35, Nikita Popov wrote: > I've still got a question about the &string_arg on line 1.9 and if it > should be changed to a string but that change needs working through the > following code. > > > Yes, this should be changed to a string. E.g. use the 'S' zpp modifier > and declare the variable as 'zend_string *str'. Then modify the places > where it is used from Z_STRVAL_P(...) to str->val and Z_STRLEN_P(...) to > str->len. OK that makes sense ... and I though I was on a roll, except while I can convert one of the uses, another is feed by a zval which I then need to convert to a zend_string, but I think I can just change b_val to Z_STR*(b_val) but the compiler is saying that Z_STR is not defined? I've spent half an hour trying to dig around but not managed to find what I should be using :( -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk