Hi,
I got one fail test in 5.5, while I was tagging 5.5.7RC1
sapi/cli/tests/php_cli_server_019.phpt
The diff is :
022+ string(12) "PHP/5.5.7RC1"
022- string(13) "P%s"
Seems like %s does not catch the version number or something like that ?
Not blocking to tag RC1 though, but should be checked and fixed.
Thx.
Julien PAULI
Hi,
I got one fail test in 5.5, while I was tagging 5.5.7RC1
sapi/cli/tests/php_cli_server_019.phpt
The diff is :
022+ string(12) "PHP/5.5.7RC1"
022- string(13) "P%s"Seems like %s does not catch the version number or something like that ?
Not blocking to tag RC1 though, but should be checked and fixed.
String length is 12 vs 13.
--
Regards,
Mike
Hi,
I got one fail test in 5.5, while I was tagging 5.5.7RC1
sapi/cli/tests/php_cli_server_019.phpt
The diff is :
022+ string(12) "PHP/5.5.7RC1"
022- string(13) "P%s"Seems like %s does not catch the version number or something like that ?
Not blocking to tag RC1 though, but should be checked and fixed.String length is 12 vs 13.
Great catch.
However, version string has a variable size, depending on the presence of
extra version (aka : RCx) or not.
I guess something like string(%d) is better then ?
Julien Pauli
Hi,
I got one fail test in 5.5, while I was tagging 5.5.7RC1
sapi/cli/tests/php_cli_server_019.phpt
The diff is :
022+ string(12) "PHP/5.5.7RC1"
022- string(13) "P%s"Seems like %s does not catch the version number or something like that ?
Not blocking to tag RC1 though, but should be checked and fixed.String length is 12 vs 13.
Great catch.
However, version string has a variable size, depending on the presence of
extra version (aka : RCx) or not.
I guess something like string(%d) is better then ?Julien Pauli
I patched it and commited it.
Perhaps my pushes on git have not been done the right way, I'm just a
beginner about that. I asked on IRC. Everything seems all right
Julien Pauli
I got one fail test in 5.5, while I was tagging 5.5.7RC1
sapi/cli/tests/php_cli_server_019.phpt
The diff is :
022+ string(12) "PHP/5.5.7RC1"
022- string(13) "P%s"Seems like %s does not catch the version number or something like that ?
Not blocking to tag RC1 though, but should be checked and fixed.
_019? That sounds awfully familiar. In fact, without checking, I'm
pretty sure that's my fault. I didn't consider a different string length
at the time, which was pretty silly of me. My apologies :)
--
Andrea Faulds
http://ajf.me/
Hi all,
sapi/cli/tests/php_cli_server_019.phpt
The diff is :
022+ string(12) "PHP/5.5.7RC1"
022- string(13) "P%s"
Any reason "P%s" instead of "PHP/%s"?
Just curious.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net