Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70431 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 15184 invoked from network); 26 Nov 2013 23:50:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Nov 2013 23:50:59 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 198.187.29.240 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 198.187.29.240 imap2-1.ox.registrar-servers.com Received: from [198.187.29.240] ([198.187.29.240:57416] helo=imap2-1.ox.registrar-servers.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 39/0F-39355-1E335925 for ; Tue, 26 Nov 2013 18:50:58 -0500 Received: from [192.168.0.13] (unknown [94.13.99.191]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by oxmail.registrar-servers.com (Postfix) with ESMTPSA id 81DC15A008F; Tue, 26 Nov 2013 18:50:51 -0500 (EST) Message-ID: <529533D5.4070804@ajf.me> Date: Tue, 26 Nov 2013 23:50:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Julien Pauli , PHP Internals References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] One fail test in 5.5 branch From: ajf@ajf.me (Andrea Faulds) On 26/11/13 15:49, Julien Pauli wrote: > > I got one fail test in 5.5, while I was tagging 5.5.7RC1 > > sapi/cli/tests/php_cli_server_019.phpt > > The diff is : > > 022+ string(12) "PHP/5.5.7RC1" > 022- string(13) "P%s" > > > Seems like %s does not catch the version number or something like that ? > Not blocking to tag RC1 though, but should be checked and fixed. > _019? That sounds awfully familiar. In fact, without checking, I'm pretty sure that's my fault. I didn't consider a different string length at the time, which was pretty silly of me. My apologies :) -- Andrea Faulds http://ajf.me/