Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70411
Return-Path: <julienpauli@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 63983 invoked from network); 26 Nov 2013 17:08:35 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 26 Nov 2013 17:08:35 -0000
Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.169 as permitted sender)
X-PHP-List-Original-Sender: julienpauli@gmail.com
X-Host-Fingerprint: 209.85.128.169 mail-ve0-f169.google.com  
Received: from [209.85.128.169] ([209.85.128.169:61371] helo=mail-ve0-f169.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 1D/E4-39355-295D4925 for <internals@lists.php.net>; Tue, 26 Nov 2013 12:08:35 -0500
Received: by mail-ve0-f169.google.com with SMTP id c14so4377116vea.0
        for <internals@lists.php.net>; Tue, 26 Nov 2013 09:08:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=ZcyV0/QS1vbRoQsXLH5k/BG+Kx+f12qNLK0R3wFu+e4=;
        b=MMsTFRJUbRcUVzk1SbpJ6FObRc2Mvr3vE9vDa8ZtSI+y4mT+IuiSOQ2dLbJO4gAt1C
         f4vdqEIVpUv5k+htHQt6pPDQgPsIELGYzTmXkx8tQjVjjXyXXWApe2VwHdYJ1MhEinki
         poAbzJZMgcPiAPyirDsYggN7Tp57YIiunQkyExokYkzMDrZ7uswK4cePnpQDJ7zQui8y
         JSogIyzi6xzUxUWEkdwv0LDGkdjJ61Fl3CP1mrBMFaf+XH7fGuxuXAMc7UReKyf6SkG/
         qoigNfZZfqlpo2E7nh9j2WADBBfD/gHRBeEjBFvSCEDAxMzdKuk6yuaGGyKO4VxTnjWT
         jpsA==
X-Received: by 10.220.97.145 with SMTP id l17mr879168vcn.35.1385485711800;
 Tue, 26 Nov 2013 09:08:31 -0800 (PST)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
Received: by 10.220.73.197 with HTTP; Tue, 26 Nov 2013 09:07:51 -0800 (PST)
In-Reply-To: <CAMUwpuQz85b7XV8Fufh0hPZ8UBjOdJK1MUZPXsZ3HaKh=gmzhQ@mail.gmail.com>
References: <CAMUwpuSWO59NCHUm89cT4oGMC9vn6_uXU2eNWMtvaqzWf6eDgA@mail.gmail.com>
 <CALJZF3j3vQ3892wsgBq0Aot5uYM3dP8V86m_erU5L6L200Yuvw@mail.gmail.com> <CAMUwpuQz85b7XV8Fufh0hPZ8UBjOdJK1MUZPXsZ3HaKh=gmzhQ@mail.gmail.com>
Date: Tue, 26 Nov 2013 18:07:51 +0100
X-Google-Sender-Auth: GHQmv4WPe4uGq-Y_VTBbkTdlXI4
Message-ID: <CAMUwpuRBRyzQ4iHAKj0dBa4H1sA4YCUzU0TZ8KedxYW5DiLQ1Q@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: PHP Internals <internals@lists.php.net>, Andrew Faulds <ajf@ajf.me>
Content-Type: multipart/alternative; boundary=001a11c1dd02b17e8104ec1787a7
Subject: Re: [PHP-DEV] One fail test in 5.5 branch
From: jpauli@php.net (Julien Pauli)

--001a11c1dd02b17e8104ec1787a7
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Nov 26, 2013 at 5:05 PM, Julien Pauli <jpauli@php.net> wrote:

> On Tue, Nov 26, 2013 at 4:53 PM, Michael Wallner <mike@php.net> wrote:
>
>> On 26 November 2013 16:49, Julien Pauli <jpauli@php.net> wrote:
>> > Hi,
>> >
>> > I got one fail test in 5.5, while I was tagging 5.5.7RC1
>> >
>> > sapi/cli/tests/php_cli_server_019.phpt
>> >
>> > The diff is :
>> >
>> > 022+   string(12) "PHP/5.5.7RC1"
>> > 022-   string(13) "P%s"
>> >
>> >
>> > Seems like %s does not catch the version number or something like that ?
>> > Not blocking to tag RC1 though, but should be checked and fixed.
>>
>> String length is 12 vs 13.
>>
>
> Great catch.
> However, version string has a variable size, depending on the presence of
> extra version (aka : RCx) or not.
> I guess something like string(%d) is better then ?
>
> Julien Pauli
>

I patched it and commited it.

Perhaps my pushes on git have not been done the right way, I'm just a
beginner about that. I asked on IRC. Everything seems all right

Julien Pauli

--001a11c1dd02b17e8104ec1787a7--