Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70408
Return-Path: <julienpauli@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 56619 invoked from network); 26 Nov 2013 16:06:32 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 26 Nov 2013 16:06:32 -0000
Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.178 as permitted sender)
X-PHP-List-Original-Sender: julienpauli@gmail.com
X-Host-Fingerprint: 209.85.220.178 mail-vc0-f178.google.com  
Received: from [209.85.220.178] ([209.85.220.178:37534] helo=mail-vc0-f178.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 6C/73-39355-707C4925 for <internals@lists.php.net>; Tue, 26 Nov 2013 11:06:31 -0500
Received: by mail-vc0-f178.google.com with SMTP id lh4so3908437vcb.23
        for <internals@lists.php.net>; Tue, 26 Nov 2013 08:06:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=4HknsUCS9E45IuP9Nlq94jrE1J25/h7jHbJLo3SPae0=;
        b=qSjNtam6EEmzINNWLIq/JTj7quuBaQ6o0rnb2+TdIvfvzCyvHNjZldHtUWkc3NErBP
         d2VK7sO0ZCkcdiD485cflbNwZBYu+Zbz32miYY6fublYhXSksnuMZi5/3bRKt21NqH1z
         Tt//Fm2WGeuIlsAaU1ayXFZ9e8aa/5izh6YqyLfE+1eZ5wSvT7PtNarQijXb5WspsN3P
         Hf5OL7nvRScqxjBrA2doQtfhF+ghgdMYIW7kdHHHFgqJOexCy8x7rDyuWgcF+3G/09fb
         0GE9B6i06oEbk/VYw0T79SzjenbsHnJfRLIWS5qaVN/QKBT6qSOlv5igSrHLb6xkUIkD
         T6FQ==
X-Received: by 10.58.181.230 with SMTP id dz6mr637824vec.35.1385481988203;
 Tue, 26 Nov 2013 08:06:28 -0800 (PST)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
Received: by 10.220.73.197 with HTTP; Tue, 26 Nov 2013 08:05:48 -0800 (PST)
In-Reply-To: <CALJZF3j3vQ3892wsgBq0Aot5uYM3dP8V86m_erU5L6L200Yuvw@mail.gmail.com>
References: <CAMUwpuSWO59NCHUm89cT4oGMC9vn6_uXU2eNWMtvaqzWf6eDgA@mail.gmail.com>
 <CALJZF3j3vQ3892wsgBq0Aot5uYM3dP8V86m_erU5L6L200Yuvw@mail.gmail.com>
Date: Tue, 26 Nov 2013 17:05:48 +0100
X-Google-Sender-Auth: 8cKWCxpHoPm1ZGVEVomkB-GRocU
Message-ID: <CAMUwpuQz85b7XV8Fufh0hPZ8UBjOdJK1MUZPXsZ3HaKh=gmzhQ@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: PHP Internals <internals@lists.php.net>, Andrew Faulds <ajf@ajf.me>
Content-Type: multipart/alternative; boundary=047d7b673bdabfeba904ec16a904
Subject: Re: [PHP-DEV] One fail test in 5.5 branch
From: jpauli@php.net (Julien Pauli)

--047d7b673bdabfeba904ec16a904
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Nov 26, 2013 at 4:53 PM, Michael Wallner <mike@php.net> wrote:

> On 26 November 2013 16:49, Julien Pauli <jpauli@php.net> wrote:
> > Hi,
> >
> > I got one fail test in 5.5, while I was tagging 5.5.7RC1
> >
> > sapi/cli/tests/php_cli_server_019.phpt
> >
> > The diff is :
> >
> > 022+   string(12) "PHP/5.5.7RC1"
> > 022-   string(13) "P%s"
> >
> >
> > Seems like %s does not catch the version number or something like that ?
> > Not blocking to tag RC1 though, but should be checked and fixed.
>
> String length is 12 vs 13.
>

Great catch.
However, version string has a variable size, depending on the presence of
extra version (aka : RCx) or not.
I guess something like string(%d) is better then ?

Julien Pauli

--047d7b673bdabfeba904ec16a904--