Fixes for parse_url, bug 50563

Instead of removing a warning, why not add an additional parameter to the
function that would instruct it to silence warning messages on parse
failure?

+1

Brian.

http://brian.moonspot.net/

Hey all,

Attached is a patch to remove the warning from parse_url() in situations
where parse_url() cannot actually parse the url. The bug report also
claims there should be a new feature for understanding "why" a parsed
url failed. That code currently does not exist, and the current warning
gives no more information than simply returning false does.

http://bugs.php.net/bug.php?id=50563

The first patch is against trunk. I think we should at least get this
done even if the group decides that down the line we want the why
portion explained as well (I actually don't care about the why part).
That feature would require that php_url_parse_ex() add some parsing
intellignce, this would not be a 1 or 2 line feature implementation.

The motivation is that since false and E_WARN are redunant, this patch
would allow developers to STOP using @parse_url(), which we have to do.

I also suggest that we apply this to the PHP_5_3 branch. This behavior
should be backwards compatible with everyone that is actually using the
@parse_url() in their code. The only 1-off situation that might be
affected is if people are catching the error with an error handler and
branching there. Why they wouldn't be branching off the false return
value, I don't know.

Both patches contain test fixes.

Is there anything more I need? Is this commit worthy?

Thanks,
Ralph

I think Kalle's patch is a really good solution for the trunk. +1

Hey Ralph

2010/5/21 Ralph Schindler ralph@smashlabs.com:

Hey all,

The first patch is against trunk. I think we should at least get this
done
even if the group decides that down the line we want the why portion
explained as well (I actually don't care about the why part). That
feature
would require that php_url_parse_ex() add some parsing intellignce, this
would not be a 1 or 2 line feature implementation.

I did a quick and dirty patch to turn the $component into a bitfield
allowing you to do:
$url = parse_url('http://www.php.net/manual/', PHP_URL_HOST |
PHP_URL_PATH);
printf('%s%s', $url['host'], $url['path']);

At the same point I figured we could disable the warning and therefore
I added a new constant named PHP_URL_SILENT:
$broken_url = 'http:///www.php.net/';
var_dump(parse_url($broken_url), parse_url($broken_url, PHP_URL_SILENT));

It doesn't alter the actual URL parser code to tell why the parsing
failed, but it kills two flies in one hit. Ofcourse the silent option
can be skipped, but while atleast updating parse_url().

Patch available at, this is a rough patch and does not fix the broken
tests:
http://pastie.org/974449

Theres a minor BC break, since it changes the values of the constants,
but it can be fixed by changing the checking code, or the dirty way to
increase the values so they don't conflict with the old ones.

--
regards,

Kalle Sommer Nielsen
kalle@php.net