Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:48427 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70343 invoked from network); 24 May 2010 11:31:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 May 2010 11:31:04 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.221.179 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.221.179 mail-qy0-f179.google.com Received: from [209.85.221.179] ([209.85.221.179:37752] helo=mail-qy0-f179.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0A/64-33110-5736AFB4 for ; Mon, 24 May 2010 07:31:02 -0400 Received: by qyk9 with SMTP id 9so5236972qyk.2 for ; Mon, 24 May 2010 04:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=TnUV3oMIZusRW5OXNR7AMUzf+I4X7Vrpl8IJqlPOAUA=; b=KP4PJZxYp9Va5HsX+34wGwis0AMM7MZiAnLlg4zN1Wzm05v3TWlNj5N6Y3AdDafmSk IWN/kGnjE7eb0bMQdAcdbVFv2j0+B8Us4USUzqYqHwW7fIlghljIGZS3Bm9n6iAVQrvt AZ+K3VRuKY4hGScWDvFbb1WjT10IOmHEfXHTs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=tkwLjuEzQgwMWnu5/hNGjIuG9/Z0FzDZKNCGCqB+bk6gCla185q1x4boGThesuF5gJ yx5OXoKPxLW41b7arh2EA0+oU73pNJMO3ymEzqfNn9KFB5Bt4X97mMOdPd757Qlra7hm BRZiIe6886TAZ8cRfcDbg1Qp/EUrTb3CPbnCw= MIME-Version: 1.0 Received: by 10.224.69.136 with SMTP id z8mr2902648qai.233.1274700659076; Mon, 24 May 2010 04:30:59 -0700 (PDT) Received: by 10.224.54.135 with HTTP; Mon, 24 May 2010 04:30:59 -0700 (PDT) In-Reply-To: References: <4BF6A90D.8020901@smashlabs.com> <4BF6AD07.7090001@moonspot.net> Date: Mon, 24 May 2010 13:30:59 +0200 Message-ID: To: Ilia Alshanetsky Cc: Brian Moon , Ralph Schindler , internals Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Fixes for parse_url, bug 50563 From: pierre.php@gmail.com (Pierre Joye) hi, I will apply the patch to trunk later today as it seems that we have no objection for the patch itself. The proposal to add more information on failure can be implemented later, if someone fills motivated enough to do it. Cheers, -- Pierre On Sat, May 22, 2010 at 5:28 PM, Pierre Joye wrote: > hi, > > On Sat, May 22, 2010 at 4:42 PM, Ilia Alshanetsky wrote: >> Instead of removing a warning, why not add an additional parameter to the >> function that would instruct it to silence warning messages on parse >> failure? > > What are the actual usefulness of these warnings? I see absolutely no > need to keep them. > > However, it would be useful to have an optional parameter to get why > an URL actually failed. But that can be done later. > > Cheers, > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org