Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:48448
Return-Path: <pierre.php@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 66974 invoked from network); 24 May 2010 19:12:21 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 May 2010 19:12:21 -0000
Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad
Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
DomainKey-Status: bad
X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01
X-PHP-List-Original-Sender: pierre.php@gmail.com
X-Host-Fingerprint: 74.125.82.42 mail-ww0-f42.google.com  
Received: from [74.125.82.42] ([74.125.82.42:46056] helo=mail-ww0-f42.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id AA/A9-13219-59FCAFB4 for <internals@lists.php.net>; Mon, 24 May 2010 15:12:21 -0400
Received: by wwb28 with SMTP id 28so332532wwb.29
        for <internals@lists.php.net>; Mon, 24 May 2010 12:12:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:in-reply-to
         :references:date:message-id:subject:from:to:cc:content-type;
        bh=OyUlTHKVK4IztlE/u4Ab8/YIVHH4Dx6QxMMDhwfO8f8=;
        b=e/TE1m4NdUi09RQK8LXvYWbnsVBzmWujvqEX94oFqfOauiZl9LWM6qDAfMKHtX3Cmm
         PYeDHY7WoIzd4EmvMdKhzy4+g9Mjl9eamnAnVGwJw3uZbtiEe90EgC9kMZJtMfMzbV5o
         xppryHBbV3A9Z9sAHN1ZPga4o0FDYvT6rSFZ0=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=dWrwuMUX6A2TDnjbuN9BLe+PJLhs1h1pnQlonu0LsvJ7J7VdPBt6CaYVBCKRru6oLg
         Q7SgpgFd1+UXEegduRj7/ihiINo3ij/0X6bpj1zgJsb1cWyRPLj+PMi8h5aA/134r6Cw
         4HfBmXUS3zUIgqGd1vpOUXuDgqNJ8BbJP6U/A=
MIME-Version: 1.0
Received: by 10.216.85.7 with SMTP id t7mr3782106wee.114.1274728338330; Mon, 
	24 May 2010 12:12:18 -0700 (PDT)
Received: by 10.216.221.34 with HTTP; Mon, 24 May 2010 12:12:18 -0700 (PDT)
In-Reply-To: <AANLkTikG2wtk78UDtz4Zo45pgifX57eHaPgJkJJyidiV@mail.gmail.com>
References: <4BF6A90D.8020901@smashlabs.com>
	 <AANLkTikq_sbVfSbL67fVOoepCm2ewvQVc15XdtjsXipO@mail.gmail.com>
	 <AANLkTikG2wtk78UDtz4Zo45pgifX57eHaPgJkJJyidiV@mail.gmail.com>
Date: Mon, 24 May 2010 21:12:18 +0200
Message-ID: <AANLkTimWZJVjXf27FGjidTcon_dYsf0Oxv2J76i2cS0S@mail.gmail.com>
To: Ilia Alshanetsky <ilia@prohost.org>
Cc: Kalle Sommer Nielsen <kalle@php.net>, Ralph Schindler <ralph@smashlabs.com>, 
	internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Fixes for parse_url, bug 50563
From: pierre.php@gmail.com (Pierre Joye)

hi,

On Mon, May 24, 2010 at 8:58 PM, Ilia Alshanetsky <ilia@prohost.org> wrote:
> I think Kalle's patch is a really good solution for the trunk. +1

Same here, with a couple of changes like killing the warning (and the
related flag) as well as removing the duplicated code. I will do that
before applying it.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org