Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:48432
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=qpW+g6gIV2E3QB+U5e8v6833oaYMfH3Ym7j5g7XTID1EEBWSRlPD6rbpjXSJvDsOvS
         MFCCjFQkx3sHnVjbrfdchhNRHGbIabbX8gBMuS7eVV9UBTMxZlVN5fo+CTeoTYu8WUkF
         VKJ1ROGKEzFMbC/ACDwthQGgHPxDNQpzpX4Ks=
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <4BF6A90D.8020901@smashlabs.com>
References: <4BF6A90D.8020901@smashlabs.com>
Date: Mon, 24 May 2010 14:51:48 +0200
Message-ID: <AANLkTikq_sbVfSbL67fVOoepCm2ewvQVc15XdtjsXipO@mail.gmail.com>
To: Ralph Schindler <ralph@smashlabs.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Fixes for parse_url, bug 50563
From: kalle@php.net (Kalle Sommer Nielsen)

Hey Ralph

2010/5/21 Ralph Schindler <ralph@smashlabs.com>:
>
> Hey all,
>
> The first patch is against trunk. =A0I think we should at least get this =
done
> even if the group decides that down the line we want the why portion
> explained as well (I actually don't care about the why part). That featur=
e
> would require that php_url_parse_ex() add some parsing intellignce, this
> would not be a 1 or 2 line feature implementation.

I did a quick and dirty patch to turn the $component into a bitfield
allowing you to do:
$url =3D parse_url('http://www.php.net/manual/', PHP_URL_HOST | PHP_URL_PAT=
H);
printf('%s%s', $url['host'], $url['path']);

At the same point I figured we could disable the warning and therefore
I added a new constant named PHP_URL_SILENT:
$broken_url =3D 'http:///www.php.net/';
var_dump(parse_url($broken_url), parse_url($broken_url, PHP_URL_SILENT));

It doesn't alter the actual URL parser code to tell why the parsing
failed, but it kills two flies in one hit. Ofcourse the silent option
can be skipped, but while atleast updating parse_url().

Patch available at, this is a rough patch and does not fix the broken tests=
:
http://pastie.org/974449

Theres a minor BC break, since it changes the values of the constants,
but it can be fixed by changing the checking code, or the dirty way to
increase the values so they don't conflict with the old ones.

--=20
regards,

Kalle Sommer Nielsen
kalle@php.net