Hi Andrei, all,
<Weekly nag alert />Can we please have a clear, on-list explanation of the reason(s) the
non-Unicode mode blocks can't be cleared out of core in CVS HEAD today?
As in, if (!UG(unicode))....
Thanks,
- Steph
Is there a patch that does that? I'm fine with removing these checks.
-Andrei
Steph Fox wrote:
Hi Andrei, all,
<Weekly nag alert />Can we please have a clear, on-list explanation of the reason(s) the
non-Unicode mode blocks can't be cleared out of core in CVS HEAD today?As in, if (!UG(unicode))....
Thanks,
- Steph
Is there a patch that does that? I'm fine with removing these checks.
If there isn't already, there soon will be :)
Did you want to review it prior to commit?
- Steph
Sure.
Steph Fox wrote:
Is there a patch that does that? I'm fine with removing these checks.
If there isn't already, there soon will be :)
Did you want to review it prior to commit?
- Steph
Hi all,
Andrei doesn't have time to review this lot (covers ext/standard). Could
someone please check it for clangers?
Thanks,
- Steph
Sure.
Steph Fox wrote:
Is there a patch that does that? I'm fine with removing these checks.
If there isn't already, there soon will be :)
Did you want to review it prior to commit?
- Steph
Hi all
Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu:
Hi all,
Andrei doesn't have time to review this lot (covers ext/standard). Could
someone please check it for clangers?Thanks,
- Steph
Here's the rest (ext/* and main/*):
http://felipe.ath.cx/diff/unicode-check.diff
- Removed:
- if (UG(unicode))
- unicode_semantics() function
- pcre_cache_entry.unicode_mode - Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_ex
MySQL part:
http://felipe.ath.cx/diff/mysql-unicode-check.diff
http://felipe.ath.cx/diff/mysql-tests-unicode-checks.diff
(removed the ini_set("unicode.semantics") checks)
MySQL guys, the non-unicode tests can be removed? (those that uses
SKIPIF...)
Sure.
Steph Fox wrote:
Is there a patch that does that? I'm fine with removing these checks.
If there isn't already, there soon will be :)
Did you want to review it prior to commit?
- Steph
--
--
Regards,
Felipe Pena.
Hey Felipe,
'Scuse top-posting, my >>s have let me down again.
Two things: first, I did in ext/standard exactly as you did elsewhere (you
know this already but the rest don't). Second, I already sent the MySQL guys
some bits and pieces for their tests.
Oh, and third - if nobody gets back to us by Friday over these patches we'll
just commit :) Don't know about Felipe's larger corner, but I tested mine to
death already.
- Steph
----- Original Message -----
From: "Felipe Pena" felipensp@gmail.com
To: "Steph Fox" steph@phparch.com
Cc: "Andrei Zmievski" andrei@gravitonic.com; "internals"
internals@lists.php.net
Sent: Monday, June 09, 2008 7:49 PM
Subject: Re: [PHP-DEV] Re: Focus on HEAD
Hi all
Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu:
Hi all,
Andrei doesn't have time to review this lot (covers ext/standard). Could
someone please check it for clangers?Thanks,
- Steph
Here's the rest (ext/* and main/*):
http://felipe.ath.cx/diff/unicode-check.diff
- Removed:
- if (UG(unicode))
- unicode_semantics() function
- pcre_cache_entry.unicode_mode - Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_ex
MySQL part:
http://felipe.ath.cx/diff/mysql-unicode-check.diff
http://felipe.ath.cx/diff/mysql-tests-unicode-checks.diff
(removed the ini_set("unicode.semantics") checks)
MySQL guys, the non-unicode tests can be removed? (those that uses
SKIPIF...)
Sure.
Steph Fox wrote:
Is there a patch that does that? I'm fine with removing these checks.
If there isn't already, there soon will be :)
Did you want to review it prior to commit?
- Steph
--
--
Regards,
Felipe Pena.
Hi!
Oh, and third - if nobody gets back to us by Friday over these patches
we'll just commit :) Don't know about Felipe's larger corner, but I
tested mine to death already.
I think it would also be nice to tag it before the change, just in case.
Stanislav Malyshev, Zend Software Architect
stas@zend.com http://www.zend.com/
(408)253-8829 MSN: stas@zend.com
Hi!
Oh, and third - if nobody gets back to us by Friday over these patches
we'll just commit :) Don't know about Felipe's larger corner, but I
tested mine to death already.I think it would also be nice to tag it before the change, just in case.
Good point, we always tag it before committing large patches.
--
Wbr,
Antony Dovgal
Oh, and third - if nobody gets back to us by Friday over these patches
we'll just commit :) Don't know about Felipe's larger corner, but I
tested mine to death already.I think it would also be nice to tag it before the change, just in case.
Oooh, exciting stuff :)
- Steph
--
Stanislav Malyshev, Zend Software Architect
stas@zend.com http://www.zend.com/
(408)253-8829 MSN: stas@zend.com
Yes, good idea. PRE-BFUC (PRE-BigFreakingUnicodeCleanup)
-Andrei
Stanislav Malyshev wrote:
Hi!
Oh, and third - if nobody gets back to us by Friday over these patches
we'll just commit :) Don't know about Felipe's larger corner, but I
tested mine to death already.I think it would also be nice to tag it before the change, just in case.
Hello,
just to inform, I've commited (yesterday) the patch removing the
UG(unicode) checks, etc across all source (except mysql exts). As the
patch has 492K, looks as no mail will be sent.
-
- ZendEngine2/zend.c
-
ZendEngine2/zend.h
-
ZendEngine2/zend_API.c
-
ZendEngine2/zend_API.h
-
ZendEngine2/zend_builtin_functions.c
-
ZendEngine2/zend_closures.c
-
ZendEngine2/zend_compile.c
-
ZendEngine2/zend_constants.c
-
ZendEngine2/zend_exceptions.c
-
ZendEngine2/zend_execute.c
-
ZendEngine2/zend_execute_API.c
-
ZendEngine2/zend_hash.c
-
ZendEngine2/zend_ini.c
-
ZendEngine2/zend_ini_parser.y
-
ZendEngine2/zend_language_parser.y
-
ZendEngine2/zend_language_scanner.c
-
ZendEngine2/zend_language_scanner.l
-
ZendEngine2/zend_language_scanner_defs.h
-
ZendEngine2/zend_object_handlers.c
-
ZendEngine2/zend_operators.c
-
ZendEngine2/zend_operators.h
-
ZendEngine2/zend_unicode.h
-
ZendEngine2/zend_variables.c
-
ZendEngine2/zend_vm_def.h
-
ZendEngine2/zend_vm_execute.h
-
ext/calendar/calendar.c
-
ext/com_dotnet/com_variant.c
-
ext/date/php_date.c
-
ext/dom/php_dom.c
-
ext/gettext/gettext.c
-
ext/iconv/iconv.c
-
ext/libxml/libxml.c
-
ext/libxml/php_libxml.h
-
ext/oci8/oci8.c
-
ext/oci8/oci8_collection.c
-
ext/oci8/oci8_interface.c
-
ext/oci8/oci8_lob.c
-
ext/oci8/oci8_statement.c
-
ext/pcre/php_pcre.c
-
ext/pcre/php_pcre.h
-
ext/pdo/pdo_dbh.c
-
ext/pdo/pdo_stmt.c
-
ext/reflection/php_reflection.c
-
ext/session/mod_files.c
-
ext/session/session.c
-
ext/simplexml/simplexml.c
-
ext/soap/php_encoding.c
-
ext/soap/php_http.c
-
ext/soap/php_packet_soap.c
-
ext/soap/soap.c
-
ext/spl/php_spl.c
-
ext/spl/spl_array.c
-
ext/spl/spl_directory.c
-
ext/spl/spl_dllist.c
-
ext/spl/spl_engine.h
-
ext/spl/spl_functions.c
-
ext/spl/spl_heap.c
-
ext/spl/spl_iterators.c
-
ext/spl/spl_observer.c
-
ext/sqlite/sqlite.c
-
ext/standard/array.c
-
ext/standard/basic_functions.c
-
ext/standard/dir.c
-
ext/standard/file.c
-
ext/standard/formatted_print.c
-
ext/standard/head.c
-
ext/standard/html.c
-
ext/standard/http_fopen_wrapper.c
-
ext/standard/incomplete_class.c
-
ext/standard/link.c
-
ext/standard/php_incomplete_class.h
-
ext/standard/proc_open.c
-
ext/standard/streamsfuncs.c
-
ext/standard/string.c
-
ext/standard/type.c
-
ext/standard/uniqid.c
-
ext/standard/var.c
-
ext/standard/var_unserializer.c
-
ext/standard/var_unserializer.re
-
ext/tidy/tidy.c
-
ext/tokenizer/tokenizer.c
-
ext/xml/xml.c
-
ext/xmlreader/php_xmlreader.c
-
main/SAPI.c
-
main/php_variables.c
-
main/rfc1867.c
-
main/spprintf.c
-
main/streams/streams.c:
-
- Removed:
-
- UG(unicode) checks
-
- pcre_cache_entry.unicode_mode
-
- Changed:
-
- ZEND_STR_TYPE -> IS_UNICODE
-
- convert_to_text -> convert_to_unicode
-
- convert_to_text_ex -> convert_to_unicode_ex
-
(Felipe, Steph)
Thanks.
--
Regards,
Felipe Pena
2009/3/27 Felipe Pena felipensp@gmail.com:
Hello,
just to inform, I've commited (yesterday) the patch removing the
UG(unicode) checks, etc across all source (except mysql exts). As the
patch has 492K, looks as no mail will be sent.
[...]
- (Felipe, Steph)
Kudos!!
-Hannes
2009/3/27 Hannes Magnusson hannes.magnusson@gmail.com:
2009/3/27 Felipe Pena felipensp@gmail.com:
Hello,
just to inform, I've commited (yesterday) the patch removing the
UG(unicode) checks, etc across all source (except mysql exts). As the
patch has 492K, looks as no mail will be sent.
[...]
Would you mind letting the list know when the commit has gone through?
That way we can catch any possible bugs quicker? (I know we could
simply do cvs up -dP repeatedly until we see changes but y'know ;-))
Thanks a million
D
David Coallier wrote:
2009/3/27 Hannes Magnusson hannes.magnusson@gmail.com:
2009/3/27 Felipe Pena felipensp@gmail.com:
Hello,
just to inform, I've commited (yesterday) the patch removing the
UG(unicode) checks, etc across all source (except mysql exts). As the
patch has 492K, looks as no mail will be sent.
[...]Would you mind letting the list know when the commit has gone through?
That way we can catch any possible bugs quicker? (I know we could
simply do cvs up -dP repeatedly until we see changes but y'know ;-))
It went through last night, its the first line of his email...
Scott
Felipe Pena schrieb:
- Removed:
- UG(unicode) checks
- pcre_cache_entry.unicode_mode
- Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_ex
(Felipe, Steph)
Yay you!
--
Sebastian Bergmann Co-Founder and Principal Consultant
http://sebastian-bergmann.de/ http://thePHP.cc/
2009/3/27 Sebastian Bergmann sb@sebastian-bergmann.de:
Felipe Pena schrieb:
- - Removed:
- - UG(unicode) checks
- - pcre_cache_entry.unicode_mode
- - Changed:
- - ZEND_STR_TYPE -> IS_UNICODE
- - convert_to_text -> convert_to_unicode
- - convert_to_text_ex -> convert_to_unicode_ex
- (Felipe, Steph)
Yay you!
Only thing I have to say about this is: "Dar dar" sorry about this :)
--
Slan,
David
Felipe Pena wrote:
Hello,
just to inform, I've commited (yesterday) the patch removing the
UG(unicode) checks, etc across all source (except mysql exts). As the
patch has 492K, looks as no mail will be sent.
I'd given up hope of ever seeing that reach CVS :)
Thanks Felipe!
- Steph
- Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_ex
Would the cleanup include the engine - i.e. all the UG-ly stuff in
macros, functions, etc. - or only ext/* part?
Stanislav Malyshev, Zend Software Architect
stas@zend.com http://www.zend.com/
(408)253-8829 MSN: stas@zend.com
I'm working on the patch to remove stuff from Zend/*, I've yet to change
any of the macros. Will most likely leave that to last.
Scott
Stanislav Malyshev wrote:
- Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_exWould the cleanup include the engine - i.e. all the UG-ly stuff in
macros, functions, etc. - or only ext/* part?
Hi Stas,
- Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_exWould the cleanup include the engine - i.e. all the UG-ly stuff in
macros, functions, etc. - or only ext/* part?
Scott's working on the engine. We just cleaned up the rest.
- Steph
--
Stanislav Malyshev, Zend Software Architect
stas@zend.com http://www.zend.com/
(408)253-8829 MSN: stas@zend.com