Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38122
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.239 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=nvWsIpXMouKbrKvwmXhFrODOLVjIIKisjAQjE7xoS7uITfTWNF7tQZH1mm7m5Npk0C
         73jM/88t7ujgwJ5sYcZUccnYWoA+0A1eEK6aYZ6SgC1i+5iG2L5LqOA3x01f5D1g5dca
         WfSzuB0JwsvcLQaxVMJV76XUVpLz+J+1y2m5w=
To: Steph Fox <steph@phparch.com>
Cc: Andrei Zmievski <andrei@gravitonic.com>, internals <internals@lists.php.net>
In-Reply-To: <014f01c8ca59$ff770770$4401a8c0@foxbox>
References: <028f01c8c973$32e0bb70$4401a8c0@foxbox>
	 <484BFF5B.8010008@gravitonic.com> <030401c8c97f$a8ec09d0$4401a8c0@foxbox>
	 <484C5533.4000004@gravitonic.com>  <014f01c8ca59$ff770770$4401a8c0@foxbox>
Content-Type: text/plain; charset=utf-8
Date: Mon, 09 Jun 2008 15:49:03 -0300
Message-ID: <1213037343.5402.21.camel@felipe>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: Focus on HEAD
From: felipensp@gmail.com (Felipe Pena)

Hi all
Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu:
> Hi all,
> 
> Andrei doesn't have time to review this lot (covers ext/standard). Could 
> someone please check it for clangers?
> 
> Thanks,
> 
> - Steph

Here's the rest (ext/* and main/*):
http://felipe.ath.cx/diff/unicode-check.diff

- Removed:
       - if (UG(unicode))
       - unicode_semantics() function
       - pcre_cache_entry.unicode_mode
- Changed:
       - ZEND_STR_TYPE -> IS_UNICODE
       - convert_to_text -> convert_to_unicode
       - convert_to_text_ex -> convert_to_unicode_ex

MySQL part:
http://felipe.ath.cx/diff/mysql-unicode-check.diff
http://felipe.ath.cx/diff/mysql-tests-unicode-checks.diff 
(removed the ini_set("unicode.semantics") checks)

MySQL guys, the non-unicode tests can be removed? (those that uses
SKIPIF...)

> 
> >
> > Sure.
> >
> > Steph Fox wrote:
> >>
> >>> Is there a patch that does that? I'm fine with removing these checks.
> >>
> >> If there isn't already, there soon will be :)
> >>
> >> Did you want to review it prior to commit?
> >>
> >> - Steph
> >>
> >>
> >
> > 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
-- 
Regards,
Felipe Pena.