Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:38123
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain phparch.com from 64.99.136.187 cause and error)
Message-ID: <01aa01c8ca94$3a920dc0$4401a8c0@foxbox>
Reply-To: "Steph Fox" <steph@phparch.com>
To: "Felipe Pena" <felipensp@gmail.com>
Cc: "Andrei Zmievski" <andrei@gravitonic.com>,
	"internals" <internals@lists.php.net>
References: <028f01c8c973$32e0bb70$4401a8c0@foxbox> <484BFF5B.8010008@gravitonic.com> <030401c8c97f$a8ec09d0$4401a8c0@foxbox> <484C5533.4000004@gravitonic.com>  <014f01c8ca59$ff770770$4401a8c0@foxbox> <1213037343.5402.21.camel@felipe>
Date: Tue, 10 Jun 2008 01:52:14 +0100
Organization: php|architect
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="UTF-8";
	reply-type=original
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: Focus on HEAD
From: steph@phparch.com ("Steph Fox")


Hey Felipe,

'Scuse top-posting, my >>s have let me down again.

Two things: first, I did in ext/standard exactly as you did elsewhere (you 
know this already but the rest don't). Second, I already sent the MySQL guys 
some bits and pieces for their tests.

Oh, and third - if nobody gets back to us by Friday over these patches we'll 
just commit :) Don't know about Felipe's larger corner, but I tested mine to 
death already.

- Steph

----- Original Message ----- 
From: "Felipe Pena" <felipensp@gmail.com>
To: "Steph Fox" <steph@phparch.com>
Cc: "Andrei Zmievski" <andrei@gravitonic.com>; "internals" 
<internals@lists.php.net>
Sent: Monday, June 09, 2008 7:49 PM
Subject: Re: [PHP-DEV] Re: Focus on HEAD



Hi all
Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu:
> Hi all,
>
> Andrei doesn't have time to review this lot (covers ext/standard). Could
> someone please check it for clangers?
>
> Thanks,
>
> - Steph

Here's the rest (ext/* and main/*):
http://felipe.ath.cx/diff/unicode-check.diff

- Removed:
       - if (UG(unicode))
       - unicode_semantics() function
       - pcre_cache_entry.unicode_mode
- Changed:
       - ZEND_STR_TYPE -> IS_UNICODE
       - convert_to_text -> convert_to_unicode
       - convert_to_text_ex -> convert_to_unicode_ex

MySQL part:
http://felipe.ath.cx/diff/mysql-unicode-check.diff
http://felipe.ath.cx/diff/mysql-tests-unicode-checks.diff
(removed the ini_set("unicode.semantics") checks)

MySQL guys, the non-unicode tests can be removed? (those that uses
SKIPIF...)

>
> >
> > Sure.
> >
> > Steph Fox wrote:
> >>
> >>> Is there a patch that does that? I'm fine with removing these checks.
> >>
> >> If there isn't already, there soon will be :)
> >>
> >> Did you want to review it prior to commit?
> >>
> >> - Steph
> >>
> >>
> >
> >
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
-- 
Regards,
Felipe Pena.


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php