Some guys at work created this patch and have been running with it
for a while now.
Could I get a few more eyeballs on this?
http://www.brianfrance.com/software/php/curl_multi_read.patch
Quote from our internal bug:
"The attached patch implements curl_multi_info_read()
, as well as
fixing some memory leak issues and reference problems in the original
source."
Should I keep it internal or commit it?
Thanks,
Brian
please commit it, looks good.
thanks,
sterling
Some guys at work created this patch and have been running with it
for a while now.Could I get a few more eyeballs on this?
http://www.brianfrance.com/software/php/curl_multi_read.patch
Quote from our internal bug:
"The attached patch implements
curl_multi_info_read()
, as well as
fixing some memory leak issues and reference problems in the original
source."Should I keep it internal or commit it?
Thanks,
Brian
PHP_5_1 and head or just head?
It could be considered bug fix since curl_multi_info_read was there,
but not implemented.
Brian
please commit it, looks good.
thanks,
sterlingSome guys at work created this patch and have been running with it
for a while now.Could I get a few more eyeballs on this?
http://www.brianfrance.com/software/php/curl_multi_read.patch
Quote from our internal bug:
"The attached patch implements
curl_multi_info_read()
, as well as
fixing some memory leak issues and reference problems in the original
source."Should I keep it internal or commit it?
Thanks,
Brian
not having tested it, i don't know. this is certainly a RM question,
but if it doesn't break the compile, it does not look like it has the
potential to damage previously existing infrastructure.
-sterling
PHP_5_1 and head or just head?
It could be considered bug fix since curl_multi_info_read was there,
but not implemented.Brian
please commit it, looks good.
thanks,
sterlingSome guys at work created this patch and have been running with it
for a while now.Could I get a few more eyeballs on this?
http://www.brianfrance.com/software/php/curl_multi_read.patch
Quote from our internal bug:
"The attached patch implements
curl_multi_info_read()
, as well as
fixing some memory leak issues and reference problems in the original
source."Should I keep it internal or commit it?
Thanks,
Brian
Apply this to HEAD for now, and once I'll review I'll give a you a go
ahead for PHP_5_2 branch that will be created. For now we'll just add
it to our 5.2 wiki TODO list.
PHP_5_1 and head or just head?
It could be considered bug fix since curl_multi_info_read was
there, but not implemented.
Ilia Alshanetsky
Advanced Internet Designs Inc.
ilia@prohost.org
P.S. Sterling, you're alive!